Chore: don't check Program.start in SourceCode#getComments (refs #14744)#14748
Merged
Conversation
btmills
approved these changes
Jun 27, 2021
Member
btmills
left a comment
There was a problem hiding this comment.
I agree with not removing getComments() until v9 because of the timing with the upcoming v8 release. This logic change to fix it until then makes sense. Thanks for doing it!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
refs #14744
Refactors
SourceCode#getComments()to retain the intended behavior when used with Espree 8 which setsProgram.startandProgram.enddifferently than Espree 7.What changes did you make? (Give an overview)
Skip comparing comment's start/end with
Programnode's start/end, and thus don't break the loop that should get all comments around a top-level statement.Program.startused to be0in Espree 7, so the condition was alwaysfalse. Similar forProgram.end, which used to be the last index.I tried this with Espree 8.0.0-beta.1, all tests are passing except those for naming convention rules that will be fixed in #14591.
Is there anything you'd like reviewers to focus on?