Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jan 25, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #9889.

What changes did you make? (Give an overview)

I updated the messageId example to correctly use the message API. I also made the code formatting match the rest of ESLint.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

Copy link
Contributor

@betaorbust betaorbust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 084351b into eslint:master Jan 25, 2018
@platinumazure
Copy link
Member

Thanks @j-f1 for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

archived due to age This issue has been archived; please open a new issue for any further discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

messageId doc examples throw during testing.

3 participants