Codecov Report

❗ No coverage uploaded for pull request base (6.x.x@134eb16). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             6.x.x    #2031   +/-   ##
========================================
  Coverage         ?   81.06%           
  Complexity       ?     3211           
========================================
  Files            ?      229           
  Lines            ?    11804           
  Branches         ?     1568           
========================================
  Hits             ?     9569           
  Misses           ?     1650           
  Partials         ?      585           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134eb16...426d9be. Read the comment docs.

@romtsn what's about -renamesourcefileattribute SourceFile? it's been removed but it was in the official docs.

@romtsn what's about -renamesourcefileattribute SourceFile? it's been removed but it was in the official docs.

Sorry I've been meaning to leave some comments here but got lost in testing the changes 😄

So I thought that we probably don't need -renamesourcefileattribute because our sdks are open-source, and there's no reason to hide the names of the files - I think this is something the consumers can decide whether they want to hide filenames from stacktraces or not and add this on themselves. This doesn't break de-obfuscation or anything, just there for security reasons (to make it harder to find out what files are causing problems)

@marandaneto should I approve it since I can't add you as a reviewer? 🤣

Also, this is what's kept at the moment (I think we did not miss anything and I gave it thorough testing, including bytecode manipulation stuff - still works, because it happens pre-R8 phase)

This crashes on release builds on AGP 7.2.1 due to the NdkIntegration using reflection.

This crashes on release builds on AGP 7.2.1 due to the NdkIntegration using reflection.

Thanks for the report, would you mind raising a new issue with more context and stack trace? Thanks.

Yeah we'd need more details - we explicitly keep SentryNdk class, so unless there's a rule which removes it, it should work fine (also, tried to reproduce - no luck)