Feat: Add client reports #1982
Merged
Feat: Add client reports #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
commented
Apr 7, 2022
sentry/src/main/java/io/sentry/clientreport/LockingClientReportStorage.java
Outdated
Show resolved
Hide resolved
adinauer
commented
Apr 7, 2022
sentry/src/main/java/io/sentry/clientreport/ClientReportRecorder.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 6.x.x #1982 +/- ##
============================================
+ Coverage 80.73% 80.81% +0.07%
- Complexity 3051 3125 +74
============================================
Files 220 228 +8
Lines 11266 11597 +331
Branches 1506 1551 +45
============================================
+ Hits 9096 9372 +276
- Misses 1603 1646 +43
- Partials 567 579 +12
Continue to review full report at Codecov.
|
adinauer
commented
Apr 7, 2022
adinauer
commented
Apr 7, 2022
sentry/src/main/java/io/sentry/clientreport/ClientReportRecorderImpl.java
Outdated
Show resolved
Hide resolved
adinauer
commented
Apr 7, 2022
...apache-http-client-5/src/main/java/io/sentry/transport/apache/ApacheHttpClientTransport.java
Outdated
Show resolved
Hide resolved
adinauer
commented
Apr 7, 2022
adinauer
commented
Apr 7, 2022
adinauer
commented
Apr 7, 2022
sentry/src/main/java/io/sentry/clientreport/AtomicClientReportStorage.java
Outdated
Show resolved
Hide resolved
adinauer
commented
Apr 7, 2022
sentry/src/main/java/io/sentry/clientreport/AtomicClientReportStorage.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 8, 2022
marandaneto
reviewed
Apr 8, 2022
...apache-http-client-5/src/main/java/io/sentry/transport/apache/ApacheHttpClientTransport.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 8, 2022
marandaneto
reviewed
Apr 8, 2022
marandaneto
reviewed
Apr 8, 2022
marandaneto
reviewed
Apr 8, 2022
marandaneto
reviewed
Apr 8, 2022
sentry/src/main/java/io/sentry/clientreport/AtomicClientReportStorage.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 8, 2022
sentry/src/main/java/io/sentry/clientreport/AtomicClientReportStorage.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 8, 2022
sentry/src/main/java/io/sentry/clientreport/AtomicClientReportStorage.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 8, 2022
marandaneto
reviewed
Apr 8, 2022
sentry/src/main/java/io/sentry/clientreport/ClientReportKey.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 8, 2022
Member
philipphofmann
left a comment
There was a problem hiding this comment.
This is a high-level review of the code. I didn't look at any tests or too close to the code. Overall this PR looks great. Thanks for doing this @adinauer 👏
...apache-http-client-5/src/main/java/io/sentry/transport/apache/ApacheHttpClientTransport.java
Outdated
Show resolved
Hide resolved
...apache-http-client-5/src/main/java/io/sentry/transport/apache/ApacheHttpClientTransport.java
Show resolved
Hide resolved
sentry/src/main/java/io/sentry/clientreport/AtomicClientReportStorage.java
Outdated
Show resolved
Hide resolved
sentry/src/main/java/io/sentry/clientreport/AtomicClientReportStorage.java
Outdated
Show resolved
Hide resolved
sentry/src/main/java/io/sentry/clientreport/AtomicClientReportStorage.java
Show resolved
Hide resolved
sentry/src/main/java/io/sentry/clientreport/LockingClientReportStorage.java
Outdated
Show resolved
Hide resolved
sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java
Outdated
Show resolved
Hide resolved
denrase
reviewed
Apr 13, 2022
sentry/src/main/java/io/sentry/clientreport/ClientReportStorage.java
Outdated
Show resolved
Hide resolved
denrase
reviewed
Apr 13, 2022
denrase
reviewed
Apr 13, 2022
denrase
reviewed
Apr 13, 2022
denrase
reviewed
Apr 13, 2022
adinauer
commented
Apr 14, 2022
Contributor
|
If It's ok having a Classes that are not used outside of the client report can be package-private. Public methods that are in public classes and need to be used in different packages, can also be marked as internal with annotations, e.g. @bruno-garcia opinions? |
13 tasks
marandaneto
approved these changes
Apr 21, 2022
philipphofmann
approved these changes
Apr 21, 2022
Member
philipphofmann
left a comment
There was a problem hiding this comment.
Didn't see any issues from a high-level perspective. Thanks for doing this 💪
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds recording discarded events and sending them with client reports to
Sentry. Discarded events give insight into where the SDK drops certain
events like, for example, beforeSend or rate limiting.
💡 Motivation and Context
Fixes #1894
💚 How did you test it?
Unit tests, Emulator, Some local load testing to ensure counts are correct when hit from multiple threads
📝 Checklist
🔮 Next steps