Add sentry-servlet-jakarta module #1987
Conversation
| testImplementation(Config.TestLibs.kotlinTestJunit) | ||
| testImplementation(Config.TestLibs.mockitoKotlin) | ||
| testImplementation(Config.TestLibs.awaitility) | ||
| } |
There was a problem hiding this comment.
pulling in spring-boot-starter-test:3.0.0-M2 would have required Java 17
| } | ||
| } | ||
|
|
||
| fun mockRequest(url: String, method: String = "GET", headers: Map<String, Any?> = emptyMap()): HttpServletRequest { |
There was a problem hiding this comment.
This is a minimalistic replacement for MockHttpServletRequestBuilder and MockHttpServletRequest from spring-test which I didn't want to pull in to avoid Java 17.
|
|
||
| verify(fixture.hub).addBreadcrumb( | ||
| check { it: Breadcrumb -> | ||
| assertEquals("/some-uri", it.getData("url")) |
There was a problem hiding this comment.
This assertion differs from the one for sentry-servlet as we simply set requestURI to the full url including protocol and host there which is not what getRequestURI usually returns according to https://docs.oracle.com/javaee/5/api/javax/servlet/http/HttpServletRequest.html#getRequestURI()
maciejwalkowiak
left a comment
There was a problem hiding this comment.
Looks good. Have you considered adding a sample project so that we can easily verify that it actually works on servlet container supporting Jakarta EE?
Going to add it |
| maven:io.sentry:sentry-spring: | ||
| maven:io.sentry:sentry-spring-boot-starter: | ||
| maven:io.sentry:sentry-servlet: | ||
| maven:io.sentry:sentry-servlet-jakarta: |
There was a problem hiding this comment.
Doing it on this PR will fail the publish release since it does not exist under https://github.com/getsentry/sentry-release-registry yet
There was a problem hiding this comment.
Created a PR for adding it there: getsentry/sentry-release-registry#69
📜 Description
Add
sentry-servlet-jakartamodule to supportjakarta.servlet-apiwhich has been moved fromjavax.servlet-api.💡 Motivation and Context
Partially fixes #1789
Spring and Spring Boot require more investigation: #1984
💚 How did you test it?
📝 Checklist
🔮 Next steps