update devcontainer stub (vscode customizations) #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on vscode docs, in the devcontainer.json file, all the vscode extensions should be listed under customizations => vscode => extensions.
https://code.visualstudio.com/docs/devcontainers/containers#_create-a-devcontainerjson-file
https://containers.dev/implementors/json_reference/
This MR adds the proper fields to the devcontainer.stub file so the generated devcontainer.json file will work properly in vscode containers.
There is no test required for this minor bug fix, but the generated devcontainer.json file will be in the proper format after this fix and if the user decides to uncomment a specific extension, it will be installed in the container without any issue.
Please let me know if I need to do any improvement to this MR, thanks.