Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ioquatix
Copy link
Member

No description provided.

@ioquatix ioquatix requested a review from jeremyevans May 24, 2020 14:18
@ioquatix
Copy link
Member Author

There are lots of tests that write app, _ = Builder.parse_file. I've left them. The _ now becomes nil which I think is acceptable for backwards compatibility.

Can you see anything else we need to do?

cc @tenderlove

Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ioquatix ioquatix merged commit b95cb72 into rack:master May 24, 2020
@ioquatix ioquatix deleted the remove-options branch May 24, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants