[Php81] Skip Encapsed on NullToStrictStringFuncCallArgRector#2744
Merged
Conversation
Member
Author
|
@TomasVotruba CI error is possibly related to new phpstan-rules update: There were 167 errors:
1) Rector\Doctrine\Tests\Rector\ClassMethod\MakeEntitySetterNullabilityInSyncWithPropertyRector\MakeEntitySetterNullabilityInSyncWithPropertyRectorTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
_PHPStan_9a6ded56a\Nette\DI\ServiceCreationException: Service (Symplify\PHPStanRules\Rules\RequireStringArgumentInConstructorRule::__construct()): Class 'Symplify\PHPStanRules\Rules\RequireStringArgumentInConstructorRule' not found.it still error even require |
lyrixx
approved these changes
Aug 9, 2022
Member
Author
|
Close-Reopen to restart build |
Member
Author
|
rebased. |
# Failing Test for NullToStrictStringFuncCallArgRector Based on https://getrector.org/demo/b778fb29-98e6-4992-b4fa-b14a0be26429 In this case, the first argument of the mb_strlen function cannot be something else than a string, so the cast to string is useless
Member
Author
|
rebased. |
Member
|
Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2742