Fixed 🎉 /cc @leoloso

It seems cause error in other downgrade tests:

There were 5 failures:

1) Rector\Tests\DowngradePhp80\Rector\Expression\DowngradeMatchToSwitchRector\DowngradeMatchToSwitchRectorTest::test with data set #6 ('/home/runner/work/rector-src/...hp.inc')
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
     public function run($value)
     {
         static function (mixed $default) : mixed {
-            switch (true) {
-                case is_string($default):
-                    return sprintf('"%s"', $default);
-                default:
-                    return $default;
-            }
+            return match (true) {
+                    is_string($default) => sprintf('"%s"', $default),
+                    default => $default,
+                };
         };
     }

That was soooooooooo quick!!!!!!! Thanks @samsonasik 💪

I tried manually check the DowngradeReflectionGetAttributesRector, it seems due to $reflectionClass no longer typed, and it got mixed type already.

It seems needs to use original node instead of latest changed type for this use case.

It seems can be resolved by lookup variable from Param when exists on NodeTypeResolver->getType() 50f3a58

Using find first previous to get first from param seems need another tweaking, as the following code will not be processed correctly:

use ReflectionClass;

class DowngradeParamReflectionGetAttribute
{
    public function run(ReflectionClass $reflectionClass)
    {
        echo $reflectionClass->getFileName();

        if ($reflectionClass->getAttributes()) {
            return true;
        }
        return false;
    }
}

as first previous is:

echo $reflectionClass->getFileName();

which will be mixed type already after downgrade parameter type widening.

I added check not param and stil mixed type 0dd5c08

All checks have passed 🎉 @TomasVotruba it is ready for review.

It seems it will make unreliable when it reassign or unset after pull from Param, marking back to draft.

Let's try tweak by re-run refactor() when node is same and phpdoc info changed

The issue seems when PhpdocInfo->hasChanged() is true, it is not immediatelly applied the information to the Node as comment, as if the node is printed, the comment still not shown, so it is late to get information of the PHPStan type.

Let's try setDocComment() on phpdocInfo->markAsChanged()

Let's try early refresh doc Node before refresh scope c81df9c

Finally 🎉 🎉 🎉, All checks have passed 🎉 @TomasVotruba I think it is ready now 🎉 🎉 🎉

Rebased.

Thank you 👍