Further stabilize watch tests #4338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#further-stabilize-watch-testsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4338 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 206 206
Lines 7353 7353
Branches 2089 2089
=======================================
Hits 7239 7239
Misses 55 55
Partials 59 59 Continue to review full report at Codecov.
|
6ea8335 to
3cd60da
Compare
|
Looks like adding a build delay to the watch events test helped a lot, will clean this up and merge it. |
3cd60da to
2b41a5d
Compare
2b41a5d to
71df04a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This is a follow-up to the previous PR that was merged to find solutions for the remaining issues. This time I repeat flaky tests in loops.