User-configurable synchronized writes #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enabling scenarios where the application needs to sync with the console, or the application wants to keep multiple console sinks which do not need to be sync'd.
nblumhardt
reviewed
Aug 15, 2019
nblumhardt
approved these changes
Aug 20, 2019
|
🎉 |
|
This is great, exactly what I was looking for. Any idea when this might be merged to master? |
|
#82 is tracking this |
This was referenced Jul 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
#65
Does this PR introduce a breaking change?
Yes, it's a breaking change. We could make it non-breaking (and I did originally), but it's feels like it might not be worth it. Adding overloads with a new required parameter
syncRootjust for this seems a little too much.Please check if the PR fulfills these requirements
Wit the sample you can:
dotnet run -- --sync-root-separatewhich will produce garbled output:dotnet run -- --sync-root-samewhich produce properly sync'd output:dotnet run -- --sync-root-defaultwhich will not configure thesyncRoot(leaving the default as per #65: