Fix cp from readonly source #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
=========================================
+ Coverage 95.8% 95.8% +<.01%
=========================================
Files 34 34
Lines 1262 1263 +1
=========================================
+ Hits 1209 1210 +1
Misses 53 53
Continue to review full report at Codecov.
|
|
@freitagbr ready for review. Please review commit-by-commit (My commits are separate from the original PR's commits). The original PR essentially had my LGTM. |
This was referenced Nov 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of PR #555.
This rebases, cleans up a test, and fixes a bug (the original PR uses
fs.chown()instead offs.chownSync()).Fixes #98