Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reset inside a Dialog does not work if data-dismiss="modal" is set #33928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2021
Merged

Reset inside a Dialog does not work if data-dismiss="modal" is set #33928

merged 2 commits into from
May 18, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented May 10, 2021 •
edited
Loading

@GeoSot GeoSot marked this pull request as ready for review May 10, 2021 23:09
@GeoSot GeoSot requested a review from a team as a code owner May 10, 2021 23:09
@GeoSot GeoSot force-pushed the gs-modal-fix-prevent-default-on-hide branch from a848d4c to d68db77 Compare May 10, 2021 23:09
rohit2sharma95
rohit2sharma95 reviewed May 11, 2021
View reviewed changes
@GeoSot GeoSot force-pushed the gs-modal-fix-prevent-default-on-hide branch from d68db77 to 6d5a360 Compare May 11, 2021 10:06
@GeoSot GeoSot force-pushed the gs-modal-fix-prevent-default-on-hide branch from 6d5a360 to 4f29344 Compare May 13, 2021 20:42
@XhmikosR XhmikosR changed the title Reset inside a Dialog does not work if data-dismiss="modal" is set Reset inside a Dialog does not work if data-dismiss="modal" is set May 18, 2021
@XhmikosR XhmikosR merged commit 2757fbe into main May 18, 2021
@XhmikosR XhmikosR deleted the gs-modal-fix-prevent-default-on-hide branch May 18, 2021 06:26
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request May 20, 2021
@GeoSot @marvin-hinkley
Reset inside a Dialog does not work if data-dismiss="modal" is set (t…
215bcff 
…wbs#33928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rohit2sharma95 rohit2sharma95 rohit2sharma95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

js v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reset inside a Dialog does not work if data-dismiss="modal" is set.

3 participants

@GeoSot @rohit2sharma95 @XhmikosR