simplify sizemode usage

28raining · 28raining · commit edfa54399289 · 2023-08-15T20:05:34.000-07:00
diff --git a/src/traces/box/plot.js b/src/traces/box/plot.js
@@ -54,7 +54,7 @@ function plotBoxAndWhiskers(sel, axes, trace, t, isStatic) {
     var wdPos = t.wdPos || 0;
     var bPosPxOffset = t.bPosPxOffset || 0;
     var whiskerWidth = trace.whiskerwidth || 0;
-    var showWhiskers = trace.showwhiskers;
+    var showWhiskers = (trace.showwhiskers !== false);
     var notched = trace.notched || false;
     var nw = notched ? 1 - 2 * trace.notchwidth : 1;
 
@@ -97,13 +97,13 @@ function plotBoxAndWhiskers(sel, axes, trace, t, isStatic) {
         var posm1 = posAxis.l2p(lcenter + bdPos1 * nw) + bPosPxOffset;
         var sdmode = trace.sizemode === 'sd';
         var q1 = valAxis.c2p(sdmode ? d.mean - d.sd : d.q1, true);
-        var q3 = trace.sizemode === 'sd' ? valAxis.c2p(d.mean + 1 * d.sd, true) :
-                                           valAxis.c2p(d.q3, true);
+        var q3 = sdmode ? valAxis.c2p(d.mean + d.sd, true) :
+                          valAxis.c2p(d.q3, true);
         // make sure median isn't identical to either of the
         // quartiles, so we can see it
         var m = Lib.constrain(
-            trace.sizemode === 'sd' ? valAxis.c2p(d.mean, true) :
-                                      valAxis.c2p(d.med, true),
+            sdmode ? valAxis.c2p(d.mean, true) :
+                     valAxis.c2p(d.med, true),
             Math.min(q1, q3) + 1, Math.max(q1, q3) - 1
         );
 
@@ -113,7 +113,7 @@ function plotBoxAndWhiskers(sel, axes, trace, t, isStatic) {
         // - box always has d.lf, but boxpoints can be anything
         // - violin has d.lf and should always use it (boxpoints is undefined)
         // - candlestick has only min/max
-        var useExtremes = (d.lf === undefined) || (trace.boxpoints === false) || (trace.sizemode === 'sd');
+        var useExtremes = (d.lf === undefined) || (trace.boxpoints === false) || sdmode;
         var lf = valAxis.c2p(useExtremes ? d.min : d.lf, true);
         var uf = valAxis.c2p(useExtremes ? d.max : d.uf, true);
         var ln = valAxis.c2p(d.ln, true);
