Include @Inject TCK tests in the build again

sbrannen · sbrannen · commit 4dc966b04b5f · 2019-09-27T13:57:31.000+02:00
Commit 979508a removed the JUnit 4 dependency from all modules except spring-test. Unfortunately, the @Inject TCK tests (SpringAtInjectTckTests) are still based on JUnit 3. Thus, that commit accidentally excluded those tests from the build. This commit includes SpringAtInjectTckTests in the build again by introducing a test runtime dependency on the JUnit Vintage TestEngine in spring-context. See spring-projectsgh-23451
diff --git a/spring-context/spring-context.gradle b/spring-context/spring-context.gradle
@@ -39,4 +39,5 @@ dependencies {
 	testRuntime("javax.xml.bind:jaxb-api")
 	testRuntime("org.glassfish:javax.el")
 	testRuntime("org.javamoney:moneta")
+	testRuntime("org.junit.vintage:junit-vintage-engine") // for @Inject TCK
 }
diff --git a/src/checkstyle/checkstyle-suppressions.xml b/src/checkstyle/checkstyle-suppressions.xml
@@ -17,7 +17,7 @@
 	<suppress files="RootBeanDefinition" checks="EqualsHashCode" />
 
 	<!-- spring-context -->
-	<suppress files="SpringAtInjectTckTests" checks="IllegalImportCheck" />
+	<suppress files="SpringAtInjectTckTests" checks="IllegalImportCheck" id="bannedJUnit3Imports" />
 
 	<!-- spring-core -->
 	<suppress files="[\\/]src[\\/]main[\\/]java[\\/]org[\\/]springframework[\\/]asm[\\/]" checks=".*" />

Original file line number	Diff line number	Diff line change
`@@ -39,4 +39,5 @@ dependencies {`
`39`	`39`	`testRuntime("javax.xml.bind:jaxb-api")`
`40`	`40`	`testRuntime("org.glassfish:javax.el")`
`41`	`41`	`testRuntime("org.javamoney:moneta")`
	`42`	`+ testRuntime("org.junit.vintage:junit-vintage-engine") // for @Inject TCK`
`42`	`43`	`}`