Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pull] main from abetlen:main #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

[pull] main from abetlen:main #6

merged 3 commits into from
May 8, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented May 8, 2025 •
edited by sourcery-ai bot
Loading

See Commits and Changes for more details.

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update llama-cpp-python to the latest version of llama.cpp with several minor improvements and additions

New Features:

  • Added support for LLAMA4 and PIXTRAL vocabulary pre-types

Bug Fixes:

  • Fixed a typo in LLAMA_VOCAB_PRE_TYPE_CHATGLM3 constant

Enhancements:

  • Updated llama_model_quantize_params to include tensor_types
  • Added comment about Top-K sampling behavior

Build:

  • Disabled curl support in CMake configuration
  • Changed llava subdirectory path

Chores:

  • Updated project version to 0.3.9
  • Updated llama.cpp to specific commit

@pull pull bot added the ⤵️ pull label May 8, 2025
@cr-gpt CR.GPT
Copy link

cr-gpt bot commented May 8, 2025

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@pull pull bot merged commit b1d23df into Abaso007:main May 8, 2025
@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented May 8, 2025 •
edited
Loading

Reviewer's Guide

This pull request primarily updates the llama.cpp submodule to commit 8733e0cf. This introduces new vocabulary pre-tokenization types (LLAMA4, PIXTRAL), extends model quantization parameters with a tensor_types field, and includes a typo correction in llama_cpp.py. Build system changes in CMakeLists.txt disable curl and update a subdirectory path. The Python package version is bumped to "0.3.9" and a documentation comment for llama_sampler_init_top_k is updated.

File-Level Changes

Change Details Files
Updated llama.cpp submodule and package version.
  • Updated llama.cpp submodule to ggml-org/llama.cpp@8733e0cf.
  • Incremented package version to "0.3.9".
  • Added changelog entry for version 0.3.9.
 vendor/llama.cpp
CHANGELOG.md
llama_cpp/__init__.py
Enhanced vocabulary and quantization options in Python bindings.
  • Added new vocabulary pre-tokenization types: LLAMA_VOCAB_PRE_TYPE_LLAMA4 and LLAMA_VOCAB_PRE_TYPE_PIXTRAL.
  • Added tensor_types field to the llama_model_quantize_params structure and its Python type hint.
  • Corrected typo from LLAMA_VOCAV_PRE_TYPE_CHATGLM3 to LLAMA_VOCAB_PRE_TYPE_CHATGLM3.
  • Updated documentation comment for llama_sampler_init_top_k to clarify behavior for k <= 0.
 llama_cpp/llama_cpp.py
Adjusted CMake build configuration.
  • Disabled curl support by setting LLAMA_CURL to OFF.
  • Changed subdirectory target from vendor/llama.cpp/examples/llava to vendor/llama.cpp/tools/mtmd.
 CMakeLists.txt
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⤵️ pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abetlen