This repository was archived by the owner on Mar 18, 2024. It is now read-only.
chore(package-diff)!: scratch definition file no longer considered a change#780
Merged
Merged
Conversation
…change Unlocked packages are no longer considered as changed if the scratch definition file has changed.
Codecov Report
@@ Coverage Diff @@
## develop #780 +/- ##
===========================================
- Coverage 66.35% 66.22% -0.13%
===========================================
Files 46 46
Lines 1605 1593 -12
Branches 348 341 -7
===========================================
- Hits 1065 1055 -10
+ Misses 540 538 -2
Continue to review full report at Codecov.
|
azlam-abdulsalam
previously approved these changes
Dec 7, 2021
azlam-abdulsalam
left a comment
Contributor
There was a problem hiding this comment.
okie. Lets have a key call out for this in the release notes for this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlocked packages are no longer considered as changed if the scratch definition
file has changed.