Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

Refactor Install Package classes #731

Merged
azlam-abdulsalam merged 8 commits into
developfrom
feat/package-refactoring
Oct 20, 2021
Merged

Refactor Install Package classes #731
azlam-abdulsalam merged 8 commits into
developfrom
feat/package-refactoring

Conversation

@azlam-abdulsalam

@azlam-abdulsalam azlam-abdulsalam commented Oct 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • feat(execcommand): add a show progress option to execute command
  • refactor(installpackage): refactor package installation classes to remove duplication
  • Introduce a base class for all install package impl's
  • Handle pre/post aliasfy in the base class as opposed to duplicating across impl classes
  • Unlocked Package Installation to use SFDXCommandWrappers as opposed to triggering installation by itself
  • Fix assignPermSetsPostDeployment have to be executed after postDeploymentScript #729 Permsets are assigned before scripts are triggered
  • Display Script Execution Logs and commands that get triggered
  • Move all package installation classes to package
  • Deprecate Install From and only allow sfpowerscripts artifacts

azlam-abdulsalam added 2 commits October 18, 2021 10:11
feat(execcommand): add a show progress option to execute command
6fc3859 
Execute command is called for refactored package installations, this is a synchronous call which
doesnt display progress logs. This PR adds ability to display progress
refactor(installpackage): refactor package installation classes to re…
9ee1d3f 
…move duplication
@azlam-abdulsalam azlam-abdulsalam marked this pull request as ready for review October 18, 2021 22:14
@dxatscale dxatscale deleted a comment from codecov-commenter Oct 20, 2021
@codecov-commenter

codecov-commenter commented Oct 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #731 (b01108c) into develop (26aa22a) will decrease coverage by 0.10%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #731      +/-   ##
===========================================
- Coverage    64.70%   64.59%   -0.11%     
===========================================
  Files           44       44              
  Lines         1462     1466       +4     
  Branches       263      264       +1     
===========================================
+ Hits           946      947       +1     
- Misses         516      519       +3
Impacted Files Coverage Δ
...core/src/command/commandExecutor/ExecuteCommand.ts 10.71% <20.00%> (+2.38%) ⬆️
packages/core/src/command/SFDXCommand.ts 95.23% <100.00%> (ø)
packages/core/src/permsets/AssignPermissionSets.ts 92.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26aa22a...b01108c. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam merged commit 162a574 into develop Oct 20, 2021
@azlam-abdulsalam azlam-abdulsalam deleted the feat/package-refactoring branch October 20, 2021 12:43
@azlam-abdulsalam azlam-abdulsalam added this to the Release - November 21 milestone Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aly76 aly76 Awaiting requested review from aly76

Assignees

@aly76 aly76

Labels

refactor

Projects

None yet

Milestone

Release - November 21

Development

Successfully merging this pull request may close these issues.

assignPermSetsPostDeployment have to be executed after postDeploymentScript

3 participants

@azlam-abdulsalam @codecov-commenter @aly76