This repository was archived by the owner on Mar 18, 2024. It is now read-only.
feat(shell-executor): add an environment variable SPFOWERSCRIPTS_DEFAULT_SHELL to select shell#873
Merged
Merged
Conversation
…ULT_LINUX_SHELL to select shell sfpowerscripts have defaulted to utilize sh for triggering scripts, Some projects however use different implementations of shell such as bash, dash etc, This could be addressed by adding a symlink from sh to the one in the environment. However, due to difficulty in changing the docker image and other layer, an env variable is introduced which can be used to set the shell
Codecov Report
@@ Coverage Diff @@
## develop #873 +/- ##
========================================
Coverage 64.54% 64.54%
========================================
Files 49 49
Lines 1616 1616
Branches 345 345
========================================
Hits 1043 1043
Misses 573 573 Continue to review full report at Codecov.
|
…h other Posix like MacOS
aly76
approved these changes
Mar 2, 2022
azlam-abdulsalam
added a commit
that referenced
this pull request
Mar 9, 2022
…ULT_SHELL to select shell (#873) * feat(shell-executor): add an environment variable SPFOWERSCRIPTS_DEFAULT_LINUX_SHELL to select shell sfpowerscripts have defaulted to utilize sh for triggering scripts, Some projects however use different implementations of shell such as bash, dash etc, This could be addressed by adding a symlink from sh to the one in the environment. However, due to difficulty in changing the docker image and other layer, an env variable is introduced which can be used to set the shell * refactor(default-shell): remove Linux from the var name, to align with other Posix like MacOS
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sfpowerscripts have defaulted to utilize sh for triggering scripts, Some projects however use
different implementations of shell such as bash, dash etc, This could be addressed by adding a
symlink from sh to the one in the environment. However, due to difficulty in changing the docker
image and other layer, an env variable is introduced which can be used to set the shell