Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

fix(source-convert): add support for api version in source convert#884

Merged
azlam-abdulsalam merged 8 commits into
developfrom
fix/support-api-version-convert
Mar 9, 2022
Merged

fix(source-convert): add support for api version in source convert#884
azlam-abdulsalam merged 8 commits into
developfrom
fix/support-api-version-convert

Conversation

@azlam-abdulsalam

@azlam-abdulsalam azlam-abdulsalam commented Mar 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Update source convert to support api versions. This allows for artifacts built with different api version to be deployable

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@azlam-abdulsalam azlam-abdulsalam requested a review from aly76 March 9, 2022 03:43
aly76
aly76 previously approved these changes Mar 9, 2022
View reviewed changes
@azlam-abdulsalam azlam-abdulsalam requested a review from aly76 March 9, 2022 04:04
aly76
aly76 previously approved these changes Mar 9, 2022
View reviewed changes
@codecov-commenter

codecov-commenter commented Mar 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #884 (dd91644) into develop (7fa9259) will increase coverage by 1.27%.
The diff coverage is 59.75%.

❗ Current head dd91644 differs from pull request most recent head 794201a. Consider uploading reports for the commit 794201a to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #884      +/-   ##
===========================================
+ Coverage    64.34%   65.62%   +1.27%     
===========================================
  Files           49       48       -1     
  Lines         1593     1533      -60     
  Branches       355      336      -19     
===========================================
- Hits          1025     1006      -19     
+ Misses         568      527      -41
Impacted Files Coverage Δ
...ages/core/src/artifacts/ArtifactFilePathFetcher.ts 34.04% <0.00%> (+3.56%) ⬆️
...org/packageQuery/InstalledPackagesQueryExecutor.ts 40.00% <ø> (ø)
packages/core/src/package/SFPPackage.ts 84.93% <ø> (ø)
packages/core/src/org/SFPOrg.ts 56.06% <56.06%> (ø)
packages/core/src/utils/ObjectCRUDHelper.ts 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d3f12...794201a. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam merged commit 21af666 into develop Mar 9, 2022
@azlam-abdulsalam azlam-abdulsalam deleted the fix/support-api-version-convert branch March 9, 2022 04:09
@azlam-abdulsalam azlam-abdulsalam added this to the Release - March 2022 milestone Mar 9, 2022
@azlam-abdulsalam azlam-abdulsalam added refactor bug Something isn't working labels Mar 9, 2022
@azlam-abdulsalam azlam-abdulsalam mentioned this pull request Mar 23, 2022
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@aly76 aly76 aly76 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working refactor

Projects

None yet

Milestone

Release - April 2022

Development

Successfully merging this pull request may close these issues.

3 participants

@azlam-abdulsalam @codecov-commenter @aly76