Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

Override API version for unlocked and source package installation#885

Merged
azlam-abdulsalam merged 2 commits into
developfrom
api-version-override
Mar 9, 2022
Merged

Override API version for unlocked and source package installation#885
azlam-abdulsalam merged 2 commits into
developfrom
api-version-override

Conversation

@aly76

@aly76 aly76 commented Mar 9, 2022 •
edited by azlam-abdulsalam
Loading

Copy link
Copy Markdown
Contributor
  • API version from artifact metadata is used for unlocked and source package
    installation
  • sourceApiVersion is copied from sfdx-project.json to artifact metadata, when creating packages
  • For backwards compat with older artifacts, if apiVersion is undefined, then package.xml version from artifact
    metadata is used

Description

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@aly76
Override API version for unlocked and source package installation
5f46d26 
- API version from artifact metadata is used for unlocked and source package
  installation
- sourceApiVersion is copied from sfdx-project.json when creating packages
- For backwards compat with older artifacts, package.xml version in artifact
  metadata is used
@aly76 aly76 requested a review from azlam-abdulsalam March 9, 2022 05:41
@codecov-commenter

codecov-commenter commented Mar 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #885 (5f46d26) into develop (7fa9259) will increase coverage by 1.27%.
The diff coverage is 59.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #885      +/-   ##
===========================================
+ Coverage    64.34%   65.62%   +1.27%     
===========================================
  Files           49       48       -1     
  Lines         1593     1533      -60     
  Branches       355      336      -19     
===========================================
- Hits          1025     1006      -19     
+ Misses         568      527      -41
Impacted Files Coverage Δ
...ages/core/src/artifacts/ArtifactFilePathFetcher.ts 34.04% <0.00%> (+3.56%) ⬆️
...org/packageQuery/InstalledPackagesQueryExecutor.ts 40.00% <ø> (ø)
packages/core/src/package/SFPPackage.ts 84.93% <ø> (ø)
packages/core/src/org/SFPOrg.ts 56.06% <56.06%> (ø)
packages/core/src/utils/ObjectCRUDHelper.ts 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21af666...5f46d26. Read the comment docs.

azlam-abdulsalam
azlam-abdulsalam approved these changes Mar 9, 2022
View reviewed changes

@azlam-abdulsalam azlam-abdulsalam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie,, all good

@azlam-abdulsalam azlam-abdulsalam merged commit 4bc85f0 into develop Mar 9, 2022
@azlam-abdulsalam azlam-abdulsalam deleted the api-version-override branch March 9, 2022 06:33
@azlam-abdulsalam azlam-abdulsalam added the bug Something isn't working label Mar 9, 2022
@azlam-abdulsalam azlam-abdulsalam added this to the Release - March 2022 milestone Mar 9, 2022
@azlam-abdulsalam azlam-abdulsalam mentioned this pull request Mar 23, 2022
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@azlam-abdulsalam azlam-abdulsalam azlam-abdulsalam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

Release - April 2022

Development

Successfully merging this pull request may close these issues.

3 participants

@aly76 @codecov-commenter @azlam-abdulsalam