Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

fix(sfp-org): fetch artitfacts installed in the order of committed#929

Merged
azlam-abdulsalam merged 2 commits into
developfrom
fix/order-of-artifacts
Apr 7, 2022
Merged

fix(sfp-org): fetch artitfacts installed in the order of committed#929
azlam-abdulsalam merged 2 commits into
developfrom
fix/order-of-artifacts

Conversation

@azlam-abdulsalam

Copy link
Copy Markdown
Contributor

Description

sfpowerscripts display packages installed across various commands such as validate, deploy, release
etc. Currently this is being displayed in the order as it is retrieved. This could be enhanced by
displaying the same order it was commited, so it matches the deployment plan as in sfdx-project.json

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

sfpowerscripts display packages installed across various commands such as validate, deploy, release
etc. Currently this is being displayed in the order as it is retrieved. This could be enhanced by
displaying the same order it was commited, so it matches the deployment plan as in sfdx-project.json
@azlam-abdulsalam azlam-abdulsalam requested a review from aly76 April 7, 2022 01:20
@azlam-abdulsalam azlam-abdulsalam added the bug Something isn't working label Apr 7, 2022
@azlam-abdulsalam azlam-abdulsalam added this to the Release - April 2022 milestone Apr 7, 2022
@azlam-abdulsalam azlam-abdulsalam self-assigned this Apr 7, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #929 (f821e4a) into develop (4b15d09) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #929   +/-   ##
========================================
  Coverage    80.16%   80.16%           
========================================
  Files           36       36           
  Lines         1104     1104           
  Branches       238      239    +1     
========================================
  Hits           885      885           
  Misses         209      209           
  Partials        10       10           
Impacted Files Coverage Δ
packages/core/src/org/SFPOrg.ts 56.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b15d09...f821e4a. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam merged commit a23c0fa into develop Apr 7, 2022
@azlam-abdulsalam azlam-abdulsalam deleted the fix/order-of-artifacts branch April 7, 2022 02:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants