refactor: additional tweaks to eslint + prettier config

emmanuelbuah · emmanuelbuah · commit 885c66f05284 · 2020-04-16T23:08:09.000-05:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -9,19 +9,11 @@ module.exports = {
     'prettier/@typescript-eslint',
     'plugin:prettier/recommended'
   ],
+  env: {
+    "node": true,
+    "es6": true
+  },
   rules: {
-    'no-unused-vars': 'off',
-    '@typescript-eslint/no-unused-vars': [
-      'error',
-      {
-        vars: 'all',
-        args: 'after-used',
-        ignoreRestSiblings: false,
-        argsIgnorePattern: '^_',
-      },
-    ],
-    'prefer-arrow-callback': [ 'error', { 'allowNamedFunctions': true }],
-    '@typescript-eslint/explicit-function-return-type': 'off',
     'import/order': [
       'error',
       {
@@ -36,6 +28,23 @@ module.exports = {
           "caseInsensitive": true
         }
       }
-    ]
+    ],
+    'max-params': ["error", 5],
+    'no-param-reassign': 'error',
+    'no-var': 'error',
+    "no-console": ["error", { "allow": ["warn", "error"] }],
+    'no-unused-vars': 'off',
+    'prefer-arrow-callback': [ 'error', { 'allowNamedFunctions': true }],
+    "sort-keys": "warn",
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      {
+        vars: 'all',
+        args: 'after-used',
+        ignoreRestSiblings: false,
+        argsIgnorePattern: '^_',
+      },
+    ],
+    '@typescript-eslint/explicit-function-return-type': 'off'
   },
 };
diff --git a/src/migration.ts b/src/migration.ts
@@ -59,10 +59,10 @@ export interface Migration {
 
 export class Migrator {
   private defaultMigration = {
-    version: 0,
+    down: (_db: Db) => Promise.reject(`Can't go down from default`),
     name: 'default',
     up: (_db: Db) => Promise.resolve(),
-    down: (_db: Db) => Promise.reject(`Can't go down from default`),
+    version: 0,
   };
   private list: Migration[];
   private collection: Collection;
@@ -80,16 +80,16 @@ export class Migrator {
     this.options = opts
       ? opts
       : {
-          // False disables logging
-          log: true,
-          // Null or a function
-          logger: null,
-          // Enable/disable info log "already at latest."
-          logIfLatest: true,
           // Migrations collection name
           collectionName: 'migrations',
           // Mongdb url or mongo Db instance
           db: null,
+          // False disables logging
+          log: true,
+          // Enable/disable info log "already at latest."
+          logIfLatest: true,
+          // Null or a function
+          logger: null,
         };
   }
 
@@ -104,8 +104,8 @@ export class Migrator {
     this.options = Object.assign({}, this.options, opts);
 
     if (!this.options.logger && this.options.log) {
-      // tslint:disable-next-line: no-console
       this.options.logger = (level: string, ...args) =>
+        // eslint-disable-next-line no-console
         console.log(level, ...args);
     }
 
@@ -417,8 +417,8 @@ export class Migrator {
     return (
       con ||
       (await this.setControl({
-        version: 0,
         locked: false,
+        version: 0,
       }))
     );
   }
@@ -445,8 +445,8 @@ export class Migrator {
       },
       {
         $set: {
-          version: control.version,
           locked: control.locked,
+          version: control.version,
         },
       },
       {
diff --git a/test/test.spec.ts b/test/test.spec.ts
@@ -7,10 +7,10 @@ describe('Migration', () => {
 
   beforeAll(async () => {
     migrator = new Migrator({
-      log: true,
-      logIfLatest: true,
       collectionName: '_migration',
       db: { connectionUrl: dbURL },
+      log: true,
+      logIfLatest: true,
     });
     await migrator.config();
   });
