Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ryanmcdermott/clean-code-javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: AlphaWong/clean-code-javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 1 file changed
  • 7 contributors

Commits on Jul 1, 2017

  1. Update README.md 

    updating function name per #200 thanks to @marzelin to clean up some issues
    @rouzbeh84 @AlphaWong
    rouzbeh84 authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    70cac90 View commit details
    Browse the repository at this point in the history

  2. modify function name for isActiveClient

    @rouzbeh84 @AlphaWong
    rouzbeh84 authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    a642f5d View commit details
    Browse the repository at this point in the history

  3. Update README.md 

    updating L278 to `isActiveClient`
    @rouzbeh84 @AlphaWong
    rouzbeh84 authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    8dea798 View commit details
    Browse the repository at this point in the history

  4. fixed a grammatical typo 

    ...you will find that those *case*... -> ..you will find that those *cases*...
    @elliothimmelfarb @AlphaWong
    elliothimmelfarb authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    c6ceac2 View commit details
    Browse the repository at this point in the history

  5. Fix code example for duplicate code

    @Neatoro @AlphaWong
    Neatoro authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    e2091e9 View commit details
    Browse the repository at this point in the history

  6. Fix indentation

    @Neatoro @AlphaWong
    Neatoro authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    28e8e3d View commit details
    Browse the repository at this point in the history

  7. Change indentation to spaces

    @Neatoro @AlphaWong
    Neatoro authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    a5a2f35 View commit details
    Browse the repository at this point in the history

  8. Add Polish translation

    @greg-dev @AlphaWong
    greg-dev authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    6b84304 View commit details
    Browse the repository at this point in the history

  9. Just Add an Indonesia Language Link (#219) 

    * translate kata pengantar / introduction

* translate variabel

* typo

* function 1/2

* 1/2 replace

* translate ### 😂

* translate Function section in Bahasa Indonesia is done

* 1/2 SOLID translation to Bahasa Indonesia

* SOLID translation to Bahasa Indonesia is Done

* translating Error Handling to bahasa indonesia is done

* well done, translated to Bahasa Indonesia

* review 1, check typo

* review 2

* just link
    @andirkh @AlphaWong
    andirkh authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    35a819e View commit details
    Browse the repository at this point in the history

  10. Update README.md 

    Capital letters in const, remove default data in class Car
    @GrzegorzZajac000 @AlphaWong
    GrzegorzZajac000 authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    ab15825 View commit details
    Browse the repository at this point in the history

  11. Pass make, model and color in constructor

    @GrzegorzZajac000 @AlphaWong
    GrzegorzZajac000 authored and AlphaWong committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    f9ae29a View commit details
    Browse the repository at this point in the history
Loading