Use env vars as a "temporary activation"

smashwilson · smashwilson · commit c60cf773d38d · 2017-05-05T15:17:18.000-04:00
diff --git a/lib/git-shell-out-strategy.js b/lib/git-shell-out-strategy.js
@@ -57,7 +57,7 @@ export default class GitShellOutStrategy {
   exec(args, {stdin, useGitPromptServer, writeOperation} = GitShellOutStrategy.defaultExecArgs) {
     /* eslint-disable no-console */
     const subscriptions = new CompositeDisposable();
-    const diagnosticsEnabled = atom.config.get('github.gitDiagnostics');
+    const diagnosticsEnabled = process.env.ATOM_GITHUB_GIT_DIAGNOSTICS || atom.config.get('github.gitDiagnostics');
 
     const formattedArgs = `git ${args.join(' ')} in ${this.workingDir}`;
     const timingMarker = GitTimingsView.generateMarker(`git ${args.join(' ')}`);
diff --git a/lib/models/event-logger.js b/lib/models/event-logger.js
@@ -92,7 +92,7 @@ export default class EventLogger {
   }
 
   isEnabled() {
-    return atom.config.get('github.filesystemEventDiagnostics');
+    return process.env.ATOM_GITHUB_FS_EVENT_LOG || atom.config.get('github.filesystemEventDiagnostics');
   }
 
   getShortName() {
diff --git a/test/helpers.js b/test/helpers.js
@@ -195,14 +195,3 @@ after(() => {
     WorkerManager.reset(true);
   }
 });
-
-// eslint-disable-next-line jasmine/no-global-setup
-before(() => {
-  if (process.env.ATOM_GITHUB_FS_EVENT_LOG) {
-    atom.config.set('github.filesystemEventDiagnostics', true);
-  }
-
-  if (process.env.ATOM_GITHUB_GIT_DIAGNOSTICS) {
-    atom.config.set('github.gitDiagnostics', true);
-  }
-});

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ export default class EventLogger {`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`isEnabled() {`
`95`		`- return atom.config.get('github.filesystemEventDiagnostics');`
	`95`	`+ return process.env.ATOM_GITHUB_FS_EVENT_LOG \|\| atom.config.get('github.filesystemEventDiagnostics');`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`getShortName() {`