Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit d54a80e

Browse files
committed
corrected typos and wording in READMEs and MAKEMEs
1 parent 7c6abf1 commit d54a80e

File tree

5 files changed

+22
-8
lines changed

5 files changed

+22
-8
lines changed

Week1/MAKEME.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,11 @@ In the lecture we developed some utility functions to simplify making XMLHttpReq
106106
- When the user changes the selected repository, any existing repository information in your page should be cleared before displaying the new information.
107107
- Make your functions small and reusable (modular)! That means create separate functions to handle certain steps.
108108

109+
Note:
110+
111+
1. Please remove all redundant, commented-out code and console.log's from your files before pushing your homework as finished. There is no need for your mentors to review this stuff.
112+
2. Please make sure your code is well-formatted and follows the recommended naming conventions.
113+
109114
_GO WILD_
110115

111116
Again, check out the GitHub API documentation to see what kind of magic stuff you can do with it.

Week1/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ In week one we will discuss the following topics:
77
• API calls
88
```
99

10-
Here are resources that we like you to read as a preparation for the third lecture:
10+
Here are resources that we like you to read as a preparation for the first lecture:
1111

1212
### Fundamentals
1313

Week1/lecture/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Use the `live-coding` folder for all live coding.
5858

5959
### 13-xhr-html
6060

61-
- Show that HTML we want to create from the JSON data
61+
- Show an example of the HTML we want to create dynamically from the JSON data
6262

6363
### 14-xhr-first
6464

Week2/MAKEME.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ Topics discussed this week:
1111

1212
- Read this article on scopes & closures: [explaining-javascript-scope-and-closures](https://robertnyman.com/2008/10/09/explaining-javascript-scope-and-closures/)
1313

14-
- If you are still not completely clear on promises, here are some additional nice resources :ring:
14+
- If you are still not completely clear on promises, here are some additional resources :ring:
1515

16-
- [Googles post about Promises](https://developers.google.com/web/fundamentals/getting-started/primers/promises)
16+
- [Google's post about Promises](https://developers.google.com/web/fundamentals/getting-started/primers/promises)
1717
- [A nice article from David Walsh](https://davidwalsh.name/promises)
1818
- [A real life example](https://github.com/mdn/js-examples/blob/master/promises-test/index.html)
1919
- [stackoverflow](http://stackoverflow.com/questions/13343340/calling-an-asynchronous-function-within-a-for-loop-in-javascript)
@@ -31,10 +31,15 @@ _Deadline Saturday_
3131

3232
The assignment for this week is:
3333

34-
- Complete your GitHub app code as needed to meet the requirements from the assignment of week 1.
34+
- Complete your GitHub app code from the previous week, if needed, to meet the requirements from that week's assignment.
3535
- Replace all asynchronous callbacks (e.g. as used with XMLHttpRequest) by ES6 promises.
3636
- Beautify your app's styling.
3737

38+
Note:
39+
40+
1. Please remove all redundant, commented-out code and console.log's from your files before pushing your homework as finished. There is no need for your mentors to review this stuff.
41+
2. Please make sure your code is well-formatted and follows the recommended naming conventions.
42+
3843
## Step 5: Read before next lecture
3944

4045
Go trough the reading material in the [README.md](/Week3/README.md) to prepare for your next class.

Week3/MAKEME.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,19 @@ _Deadline Thursday_
2626

2727
- Fix the issues from the last weeks and make sure you explain how you fixed the issue in a comment (or commit message)
2828

29-
## Step 4: Refactor GitHub app using OOP and ES6 classes
29+
## Step 4: Refactor the GitHub app using OOP and ES6 classes
3030

3131
- If you need to refresh your memory on es6 classes: [es6-classes-in-depth](https://ponyfoo.com/articles/es6-classes-in-depth)
3232

3333
_Deadline Saturday_
3434

35-
The assignment is to refactor your GitHub to use OOP with ES6 classes (see skeleton code below). We will be introducing a `Repository` and `Contributor` class that will each be responsible for rendering their own data. A third `View` class will contain all remaining code.
35+
The assignment is to refactor your GitHub app to use OOP with ES6 classes (see skeleton code below). We will be introducing a `Repository` and a `Contributor` class that will each be responsible for rendering their own data. A third `View` class will contain all remaining code.
3636

3737
1. You should refactor your code to use three classes, named `Repository`, `Contributor` and `View`.
3838
2. Move your existing code that deals with rendering the repository information to the `render()` method of the `Repository` class.
3939
3. Move your existing code that deals with rendering the information for a single contributor to the `render()` method of the `Contributor` class.
4040
4. Move your existing code responsible for initializing your application to the `constructor` of the `View` class.
41-
5. Your remaining code should probably go to the `fetchAndRender()` method of the `View` class.
41+
5. The bulk of your remaining code should probably go to the `fetchAndRender()` method of the `View` class.
4242

4343
### Skeleton
4444

@@ -134,6 +134,10 @@ Use this skeleton as overall design for your code in `app.js`:
134134
}
135135
```
136136

137+
Note:
138+
139+
1. Please remove all redundant, commented-out code and console.log's from your files before pushing your homework as finished. There is no need for your mentors to review this stuff.
140+
2. Please make sure your code is well-formatted and follows the recommended naming conventions.
137141
## Step 6: Read before next lecture
138142

139143
_Deadline Sunday morning_

0 commit comments

Comments
 (0)