Add compatibility method for JSValue.function(_:JSClosure)

kateinoigakukun · kateinoigakukun · commit aed4312ddf77 · 2021-01-04T02:17:17.000+09:00
diff --git a/Example/JavaScriptKitExample/Sources/JavaScriptKitExample/main.swift b/Example/JavaScriptKitExample/Sources/JavaScriptKitExample/main.swift
@@ -12,6 +12,6 @@ buttonElement.innerText = "Click me!"
 let listener = JSClosure { _ in
     alert("Swift is running on browser!")
 }
-buttonElement.onclick = .function(listener)
+buttonElement.onclick = .object(listener)
 
 _ = document.body.appendChild(buttonElement)
diff --git a/Sources/JavaScriptKit/JSValue.swift b/Sources/JavaScriptKit/JSValue.swift
@@ -144,6 +144,11 @@ extension JSValue {
     public static func function(_ body: @escaping ([JSValue]) -> JSValue) -> JSValue {
         .object(JSClosure(body))
     }
+
+    @available(*, deprecated, renamed: "object", message: "JSClosure is not a subclass of JSFunction now")
+    public static func function(_ closure: JSClosure) -> JSValue {
+        .object(closure)
+    }
 }
 
 extension JSValue: ExpressibleByStringLiteral {

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,6 @@ buttonElement.innerText = "Click me!"`
`12`	`12`	`let listener = JSClosure { _ in`
`13`	`13`	`alert("Swift is running on browser!")`
`14`	`14`	`}`
`15`		`-buttonElement.onclick = .function(listener)`
	`15`	`+buttonElement.onclick = .object(listener)`
`16`	`16`
`17`	`17`	`_ = document.body.appendChild(buttonElement)`
Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,11 @@ extension JSValue {`
`144`	`144`	`public static func function(_ body: @escaping ([JSValue]) -> JSValue) -> JSValue {`
`145`	`145`	`.object(JSClosure(body))`
`146`	`146`	`}`
	`147`	`+`
	`148`	`+ @available(*, deprecated, renamed: "object", message: "JSClosure is not a subclass of JSFunction now")`
	`149`	`+ public static func function(_ closure: JSClosure) -> JSValue {`
	`150`	`+ .object(closure)`
	`151`	`+ }`
`147`	`152`	`}`
`148`	`153`
`149`	`154`	`extension JSValue: ExpressibleByStringLiteral {`