From bd40452a9ed96166104a1f06aa8b718caa6c9acc Mon Sep 17 00:00:00 2001 From: shalin-shaji Date: Mon, 23 Sep 2024 21:18:11 +0530 Subject: [PATCH 1/2] sdk- java issue :"Defaulting to non-proxy environment" log warning #172. Changed the condition to reach the mentioned log message. --- src/main/java/net/authorize/util/HttpClient.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/net/authorize/util/HttpClient.java b/src/main/java/net/authorize/util/HttpClient.java index d864dc36..f1e04cdc 100644 --- a/src/main/java/net/authorize/util/HttpClient.java +++ b/src/main/java/net/authorize/util/HttpClient.java @@ -185,7 +185,7 @@ static CloseableHttpClient getHttpsClient() throws Exception { proxySet = true; } else { - LogHelper.warn(logger, "Defaulting to non-proxy environment"); + if( UseProxy ) { LogHelper.warn(logger, "Defaulting to non-proxy environment");} httpClient = HttpClientBuilder .create() From 42006ddc6056985ea1715907b06b2a742fe5a507 Mon Sep 17 00:00:00 2001 From: shalin-shaji Date: Tue, 24 Sep 2024 10:21:35 +0530 Subject: [PATCH 2/2] sdk-java issue : "Environment not set. Set environment using setter or use overloaded method to pass appropriate environment #163" Changed 'nullEnvironmentErrorMessage' as a constant to avoid confusion. --- .../net/authorize/api/controller/base/ApiOperationBase.java | 5 ++--- src/main/java/net/authorize/util/Constants.java | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/net/authorize/api/controller/base/ApiOperationBase.java b/src/main/java/net/authorize/api/controller/base/ApiOperationBase.java index 52e3d7cc..c59b2c55 100644 --- a/src/main/java/net/authorize/api/controller/base/ApiOperationBase.java +++ b/src/main/java/net/authorize/api/controller/base/ApiOperationBase.java @@ -121,12 +121,11 @@ public S executeWithApiResponse(Environment environment) { return this.getApiResponse(); } - final String nullEnvironmentErrorMessage = "Environment not set. Set environment using setter or use overloaded method to pass appropriate environment"; public void execute() { if ( null == ApiOperationBase.getEnvironment()) { - throw new InvalidParameterException(nullEnvironmentErrorMessage); + throw new InvalidParameterException(Constants.NULL_ENVIRONMENT_ERROR_MESSAGE); } else { @@ -139,7 +138,7 @@ public void execute(Environment environment) { logger.debug(String.format("Executing Request:'%s'", this.getApiRequest())); - if ( null == environment) throw new InvalidParameterException(nullEnvironmentErrorMessage); + if ( null == environment) throw new InvalidParameterException(Constants.NULL_ENVIRONMENT_ERROR_MESSAGE); ANetApiResponse httpApiResponse = HttpUtility.postData(environment, this.getApiRequest(), this.responseClass); if ( null != httpApiResponse) diff --git a/src/main/java/net/authorize/util/Constants.java b/src/main/java/net/authorize/util/Constants.java index 2a2b42c5..500f920c 100644 --- a/src/main/java/net/authorize/util/Constants.java +++ b/src/main/java/net/authorize/util/Constants.java @@ -36,4 +36,5 @@ public final class Constants { public static final int HTTP_READ_TIME_OUT_DEFAULT_VALUE = 30000; public static final String CLIENT_ID = "sdk-java-2.0.3"; + public static final String NULL_ENVIRONMENT_ERROR_MESSAGE = "Environment not set. Set environment using setter or use overloaded method to pass appropriate environment"; }