Fix SimpleRegex#19, add test case

nicolaiunrein · nicolaiunrein · commit a313f8ee03a9 · 2021-05-17T17:14:50.000+02:00
diff --git a/lib/Builder.js b/lib/Builder.js
@@ -704,6 +704,8 @@ class Builder {
         clone._modifiers = this._modifiers
         clone._lastMethodType = this._lastMethodType
         clone._group = this._group
+        clone._captureNames = Array.from(this._captureNames)
+        clone._implodeString = this.implodeString
 
         return clone
     }
diff --git a/test/builder-test.js b/test/builder-test.js
@@ -178,4 +178,18 @@ describe('Builder isMatching', () => {
 
         assert.deepEqual(regex, /(?:foo)/)
     })
+
+    it('Stores named captures', () => {
+        const regex_new = new SRL("capture (anything once or more) as first");
+        const testcase = 'hello world';
+
+        let matches_new = regex_new.getMatch(testcase)
+        assert.equal(matches_new["first"], 'hello world')
+
+        const regex_cached = new SRL("capture (anything once or more) as first");
+
+        let matches_cached = regex_cached.getMatch(testcase)
+        assert.equal(matches_cached["first"], 'hello world')
+
+    })
 })

Original file line number	Diff line number	Diff line change
`@@ -704,6 +704,8 @@ class Builder {`
`704`	`704`	`clone._modifiers = this._modifiers`
`705`	`705`	`clone._lastMethodType = this._lastMethodType`
`706`	`706`	`clone._group = this._group`
	`707`	`+ clone._captureNames = Array.from(this._captureNames)`
	`708`	`+ clone._implodeString = this.implodeString`
`707`	`709`
`708`	`710`	`return clone`
`709`	`711`	`}`