refactor: replace side-effect list comprehensions with for loops

Brickster · Brickster · commit 2ab020aa70c6 · 2026-05-10T20:35:03.000-05:00
diff --git a/brickset/instructions.py b/brickset/instructions.py
@@ -138,9 +138,11 @@ def get_instructions(id, directory, set_number=None):
 
         fetched = instructions_json['instructions']
         if directory:
-            [download_instruction(directory, cur_set_number, i) for i in fetched]
+            for i in fetched:
+                download_instruction(directory, cur_set_number, i)
         else:
-            [_print_instruction(cur_set_number, i) for i in fetched]
+            for i in fetched:
+                _print_instruction(cur_set_number, i)
 
 
 def _print_instruction(set_number, instruction):
diff --git a/brickset/sets.py b/brickset/sets.py
@@ -108,7 +108,8 @@ def get_sets(filters: SetFilters, limit, order_by, extended, id_only, count):
     if count:
         print(sets_json['matches'])
     else:
-        [_print_set(lego_set, id_only) for lego_set in sets_json['sets']]
+        for lego_set in sets_json['sets']:
+            _print_set(lego_set, id_only)
 
 
 def update_set(id, owned, wanted, notes, rating):
