Some callback error check style cleanups

arrbee · arrbee · commit c7b3e1b32040 · 2013-12-11T10:57:50.000-08:00
I find this easier to read...
diff --git a/src/attr.c b/src/attr.c
@@ -191,10 +191,11 @@ int git_attr_foreach(
 				if (error < 0)
 					goto cleanup;
 
-				error = GITERR_CALLBACK(
-					callback(assign->name, assign->value, payload) );
-				if (error)
+				error = callback(assign->name, assign->value, payload);
+				if (error) {
+					GITERR_CALLBACK(error);
 					goto cleanup;
+				}
 			}
 		}
 	}
diff --git a/src/diff.c b/src/diff.c
@@ -1388,8 +1388,10 @@ int git_diff__paired_foreach(
 			i++; j++;
 		}
 
-		if ((error = GITERR_CALLBACK( cb(h2i, i2w, payload) )) != 0)
+		if ((error = cb(h2i, i2w, payload)) != 0) {
+			GITERR_CALLBACK(error);
 			break;
+		}
 	}
 
 	/* restore case-insensitive delta sort */
diff --git a/src/fetchhead.c b/src/fetchhead.c
@@ -260,19 +260,20 @@ int git_repository_fetchhead_foreach(git_repository *repo,
 	while ((line = git__strsep(&buffer, "\n")) != NULL) {
 		++line_num;
 
-		if ((error = fetchhead_ref_parse(&oid, &is_merge, &name, &remote_url,
-			line, line_num)) < 0)
+		if ((error = fetchhead_ref_parse(
+				&oid, &is_merge, &name, &remote_url, line, line_num)) < 0)
 			goto done;
 
 		if (git_buf_len(&name) > 0)
 			ref_name = git_buf_cstr(&name);
 		else
 			ref_name = NULL;
 
-		error = GITERR_CALLBACK(
-			cb(ref_name, remote_url, &oid, is_merge, payload) );
-		if (error)
+		error = cb(ref_name, remote_url, &oid, is_merge, payload);
+		if (error) {
+			GITERR_CALLBACK(error);
 			goto done;
+		}
 	}
 
 	if (*buffer) {
diff --git a/src/merge.c b/src/merge.c
@@ -287,8 +287,10 @@ int git_repository_mergehead_foreach(
 		if ((error = git_oid_fromstr(&oid, line)) < 0)
 			goto cleanup;
 
-		if ((error = GITERR_CALLBACK( cb(&oid, payload) )) != 0)
+		if ((error = cb(&oid, payload)) != 0) {
+			GITERR_CALLBACK(error);
 			goto cleanup;
+		}
 
 		++line_num;
 	}
diff --git a/src/pack-objects.c b/src/pack-objects.c
@@ -229,9 +229,12 @@ int git_packbuilder_insert(git_packbuilder *pb, const git_oid *oid,
 		if (elapsed >= MIN_PROGRESS_UPDATE_INTERVAL) {
 			pb->last_progress_report_time = current_time;
 
-			return GITERR_CALLBACK( pb->progress_cb(
+			ret = pb->progress_cb(
 				GIT_PACKBUILDER_ADDING_OBJECTS,
-				pb->nr_objects, 0, pb->progress_cb_payload) );
+				pb->nr_objects, 0, pb->progress_cb_payload);
+
+			if (ret)
+				return GITERR_CALLBACK(ret);
 		}
 	}
 
diff --git a/src/pack.c b/src/pack.c
@@ -1088,8 +1088,10 @@ int git_pack_foreach_entry(
 	}
 
 	for (i = 0; i < p->num_objects; i++)
-		if ((error = GITERR_CALLBACK( cb(p->oids[i], data) )) != 0)
+		if ((error = cb(p->oids[i], data)) != 0) {
+			GITERR_CALLBACK(error);
 			break;
+		}
 
 	return error;
 }
diff --git a/src/path.c b/src/path.c
@@ -434,10 +434,13 @@ int git_path_walk_up(
 	iter.asize = path->asize;
 
 	while (scan >= stop) {
-		error = GITERR_CALLBACK( cb(data, &iter) );
+		error = cb(data, &iter);
 		iter.ptr[scan] = oldc;
-		if (error)
+
+		if (error) {
+			GITERR_CALLBACK(error);
 			break;
+		}
 
 		scan = git_buf_rfind_next(&iter, '/');
 		if (scan >= 0) {
@@ -874,12 +877,14 @@ int git_path_direach(
 		if ((error = git_buf_put(path, de_path, de_len)) < 0)
 			break;
 
-		error = GITERR_CALLBACK( fn(arg, path) );
+		error = fn(arg, path);
 
 		git_buf_truncate(path, wd_len); /* restore path */
 
-		if (error)
+		if (error != 0) {
+			GITERR_CALLBACK(error);
 			break;
+		}
 	}
 
 	closedir(dir);
diff --git a/src/push.c b/src/push.c
@@ -659,8 +659,9 @@ int git_push_status_foreach(git_push *push,
 	unsigned int i;
 
 	git_vector_foreach(&push->status, i, status) {
-		GITERR_CHECK_ERROR(
-			GITERR_CALLBACK( cb(status->ref, status->msg, data) ) );
+		int error = cb(status->ref, status->msg, data);
+		if (error)
+			return GITERR_CALLBACK(error);
 	}
 
 	return 0;
diff --git a/src/remote.c b/src/remote.c
@@ -1348,9 +1348,11 @@ static int rename_fetch_refspecs(
 		if (!remote->name ||
 			strcmp(git_buf_cstr(&base), spec->string)) {
 
-			error = GITERR_CALLBACK( callback(spec->string, payload) );
-			if (error)
+			if ((error = callback(spec->string, payload)) != 0) {
+				GITERR_CALLBACK(error);
 				break;
+			}
+
 			continue;
 		}
 
diff --git a/src/stash.c b/src/stash.c
@@ -582,13 +582,15 @@ int git_stash_foreach(
 	for (i = 0; i < max; i++) {
 		entry = git_reflog_entry_byindex(reflog, i);
 
-		error = GITERR_CALLBACK(
-			callback(i,
-				git_reflog_entry_message(entry),
-				git_reflog_entry_id_new(entry),
-				payload) );
-		if (error)
+		error = callback(i,
+			git_reflog_entry_message(entry),
+			git_reflog_entry_id_new(entry),
+			payload);
+
+		if (error) {
+			GITERR_CALLBACK(error);
 			break;
+		}
 	}
 
 cleanup:
diff --git a/src/status.c b/src/status.c
@@ -392,9 +392,10 @@ int git_status_foreach_ext(
 			status_entry->head_to_index->old_file.path :
 			status_entry->index_to_workdir->old_file.path;
 
-		error = GITERR_CALLBACK( cb(path, status_entry->status, payload) );
-		if (error)
+		if ((error = cb(path, status_entry->status, payload)) != 0) {
+			GITERR_CALLBACK(error);
 			break;
+		}
 	}
 
 	git_status_list_free(status);
diff --git a/src/submodule.c b/src/submodule.c
@@ -168,8 +168,10 @@ int git_submodule_foreach(
 				break;
 		}
 
-		if ((error = GITERR_CALLBACK(callback(sm, sm->name, payload))) != 0)
+		if ((error = callback(sm, sm->name, payload)) != 0) {
+			GITERR_CALLBACK(error);
 			break;
+		}
 	});
 
 	git_vector_free(&seen);

Original file line number	Diff line number	Diff line change
`@@ -191,10 +191,11 @@ int git_attr_foreach(`
`191`	`191`	`if (error < 0)`
`192`	`192`	`goto cleanup;`
`193`	`193`
`194`		`- error = GITERR_CALLBACK(`
`195`		`- callback(assign->name, assign->value, payload) );`
`196`		`- if (error)`
	`194`	`+ error = callback(assign->name, assign->value, payload);`
	`195`	`+ if (error) {`
	`196`	`+ GITERR_CALLBACK(error);`
`197`	`197`	`goto cleanup;`
	`198`	`+ }`
`198`	`199`	`}`
`199`	`200`	`}`
`200`	`201`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1388,8 +1388,10 @@ int git_diff__paired_foreach(`
`1388`	`1388`	`i++; j++;`
`1389`	`1389`	`}`
`1390`	`1390`
`1391`		`- if ((error = GITERR_CALLBACK( cb(h2i, i2w, payload) )) != 0)`
	`1391`	`+ if ((error = cb(h2i, i2w, payload)) != 0) {`
	`1392`	`+ GITERR_CALLBACK(error);`
`1392`	`1393`	`break;`
	`1394`	`+ }`
`1393`	`1395`	`}`
`1394`	`1396`
`1395`	`1397`	`/* restore case-insensitive delta sort */`
Original file line number	Diff line number	Diff line change
`@@ -229,9 +229,12 @@ int git_packbuilder_insert(git_packbuilder pb, const git_oid oid,`
`229`	`229`	`if (elapsed >= MIN_PROGRESS_UPDATE_INTERVAL) {`
`230`	`230`	`pb->last_progress_report_time = current_time;`
`231`	`231`
`232`		`- return GITERR_CALLBACK( pb->progress_cb(`
	`232`	`+ ret = pb->progress_cb(`
`233`	`233`	`GIT_PACKBUILDER_ADDING_OBJECTS,`
`234`		`- pb->nr_objects, 0, pb->progress_cb_payload) );`
	`234`	`+ pb->nr_objects, 0, pb->progress_cb_payload);`
	`235`	`+`
	`236`	`+ if (ret)`
	`237`	`+ return GITERR_CALLBACK(ret);`
`235`	`238`	`}`
`236`	`239`	`}`
`237`	`240`
Original file line number	Diff line number	Diff line change
`@@ -1088,8 +1088,10 @@ int git_pack_foreach_entry(`
`1088`	`1088`	`}`
`1089`	`1089`
`1090`	`1090`	`for (i = 0; i < p->num_objects; i++)`
`1091`		`- if ((error = GITERR_CALLBACK( cb(p->oids[i], data) )) != 0)`
	`1091`	`+ if ((error = cb(p->oids[i], data)) != 0) {`
	`1092`	`+ GITERR_CALLBACK(error);`
`1092`	`1093`	`break;`
	`1094`	`+ }`
`1093`	`1095`
`1094`	`1096`	`return error;`
`1095`	`1097`	`}`