Fix régressions PHPStan et CS Fixer suite aux mises à jour

BySplashGm · BySplashGm · commit f0f90d1858c4 · 2026-04-24T12:02:41.000+02:00
- CS Fixer 3.95 : auto-fix des règles multiline_promoted_properties,
  braces_position et single_line_empty_body sur 35 fichiers
- PHPStan 2.1.51 : suppression des ?? null redondants sur propriétés
  non-nullables dans CompanyMemberInvitation
- PHPStan 2.1.51 : suppression du guard event_id !== null redondant
  dans TicketType (exception déjà levée en amont si null)
diff --git a/sources/Afup/Corporate/Page.php b/sources/Afup/Corporate/Page.php
@@ -10,9 +10,7 @@
 
 final readonly class Page
 {
-    public function __construct(
-        private FeuilleRepository $feuilleRepository,
-    ) {}
+    public function __construct(private FeuilleRepository $feuilleRepository,) {}
 
     public function header($url = null, UserInterface $user = null): string
     {
diff --git a/sources/AppBundle/Association/Form/CompanyPublicProfile.php b/sources/AppBundle/Association/Form/CompanyPublicProfile.php
@@ -27,9 +27,7 @@ class CompanyPublicProfile extends AbstractType
     public const DESCRIPTION_MAX_LENGTH = 2000;
     public const MEMBERSHIP_REASON_MAX_LENGTH = 150;
 
-    public function __construct(
-        private readonly AntenneRepository $antennesRepository,
-    ) {}
+    public function __construct(private readonly AntenneRepository $antennesRepository,) {}
 
     public function buildForm(FormBuilderInterface $builder, array $options): void
     {
diff --git a/sources/AppBundle/Association/Form/NearestOfficeChoiceType.php b/sources/AppBundle/Association/Form/NearestOfficeChoiceType.php
@@ -11,9 +11,7 @@
 
 class NearestOfficeChoiceType extends AbstractType
 {
-    public function __construct(
-        private readonly AntenneRepository $antennesRepository,
-    ) {}
+    public function __construct(private readonly AntenneRepository $antennesRepository,) {}
 
     public function configureOptions(OptionsResolver $resolver): void
     {
diff --git a/sources/AppBundle/Association/Model/CompanyMemberInvitation.php b/sources/AppBundle/Association/Model/CompanyMemberInvitation.php
@@ -77,7 +77,7 @@ public function getManager(): bool
 
     public function setManager(bool $manager): self
     {
-        $this->propertyChanged('manager', $this->manager ?? null, $manager);
+        $this->propertyChanged('manager', $this->manager, $manager);
         $this->manager = $manager;
         return $this;
     }
@@ -107,7 +107,7 @@ public function getStatus(): int
      */
     public function setStatus(int $status): self
     {
-        $this->propertyChanged('status', $this->status ?? null, $status);
+        $this->propertyChanged('status', $this->status, $status);
         $this->status = $status;
         return $this;
     }
diff --git a/sources/AppBundle/Command/UpdateCompanyMemberStateCommand.php b/sources/AppBundle/Command/UpdateCompanyMemberStateCommand.php
@@ -12,9 +12,8 @@
 
 class UpdateCompanyMemberStateCommand extends Command
 {
-    public function __construct(
-        private readonly CompanyMemberRepository $companyMemberRepository,
-    ) {
+    public function __construct(private readonly CompanyMemberRepository $companyMemberRepository,)
+    {
         parent::__construct();
     }
 
diff --git a/sources/AppBundle/Controller/Admin/Accounting/Journal/AllocateAction.php b/sources/AppBundle/Controller/Admin/Accounting/Journal/AllocateAction.php
@@ -12,9 +12,7 @@
 
 class AllocateAction extends AbstractController
 {
-    public function __construct(
-        private readonly TransactionRepository $transactionRepository,
-    ) {}
+    public function __construct(private readonly TransactionRepository $transactionRepository,) {}
 
     public function __invoke(Request $request, int $id): RedirectResponse
     {
diff --git a/sources/AppBundle/Controller/Admin/Accounting/Journal/UpdateInfoAction.php b/sources/AppBundle/Controller/Admin/Accounting/Journal/UpdateInfoAction.php
@@ -14,9 +14,7 @@
 
 class UpdateInfoAction extends AbstractController
 {
-    public function __construct(
-        private readonly TransactionRepository $transactionRepository,
-    ) {}
+    public function __construct(private readonly TransactionRepository $transactionRepository,) {}
 
     public function __invoke(
         Request $request,
diff --git a/sources/AppBundle/Controller/Admin/Accounting/MembershipFee/DownloadMembershipFeeInvoiceAction.php b/sources/AppBundle/Controller/Admin/Accounting/MembershipFee/DownloadMembershipFeeInvoiceAction.php
@@ -11,9 +11,7 @@
 
 class DownloadMembershipFeeInvoiceAction extends AbstractController
 {
-    public function __construct(
-        private readonly Cotisations $cotisations,
-    ) {}
+    public function __construct(private readonly Cotisations $cotisations,) {}
 
     public function __invoke(MemberType $memberType, int $memberId, int $membershipFeeId): Response
     {
diff --git a/sources/AppBundle/Controller/Admin/Audit/IndexAction.php b/sources/AppBundle/Controller/Admin/Audit/IndexAction.php
@@ -10,9 +10,7 @@
 
 final class IndexAction extends AbstractController
 {
-    public function __construct(
-        private readonly AuditLogRepository $auditLogRepository,
-    ) {}
+    public function __construct(private readonly AuditLogRepository $auditLogRepository,) {}
 
     public function __invoke(int $page): Response
     {
diff --git a/sources/AppBundle/Controller/Admin/Event/ExtendSpecialPriceAction.php b/sources/AppBundle/Controller/Admin/Event/ExtendSpecialPriceAction.php
@@ -12,9 +12,7 @@
 
 class ExtendSpecialPriceAction extends AbstractController
 {
-    public function __construct(
-        private readonly TicketSpecialPriceRepository $ticketSpecialPriceRepository,
-    ) {}
+    public function __construct(private readonly TicketSpecialPriceRepository $ticketSpecialPriceRepository,) {}
 
     public function __invoke(int $id, AdminEventSelection $eventSelection): Response
     {
diff --git a/sources/AppBundle/Controller/Admin/Event/PricesAction.php b/sources/AppBundle/Controller/Admin/Event/PricesAction.php
@@ -11,9 +11,7 @@
 
 class PricesAction extends AbstractController
 {
-    public function __construct(
-        private readonly TicketEventTypeRepository $ticketEventTypeRepository,
-    ) {}
+    public function __construct(private readonly TicketEventTypeRepository $ticketEventTypeRepository,) {}
 
     public function __invoke(AdminEventSelection $eventSelection): Response
     {
diff --git a/sources/AppBundle/Controller/Admin/Event/Session/CalendarAjaxAction.php b/sources/AppBundle/Controller/Admin/Event/Session/CalendarAjaxAction.php
@@ -11,9 +11,7 @@
 
 class CalendarAjaxAction extends AbstractController
 {
-    public function __construct(
-        private readonly PlanningRepository $planningRepository,
-    ) {}
+    public function __construct(private readonly PlanningRepository $planningRepository,) {}
 
     public function __invoke(int $id, Request $request): Response
     {
diff --git a/sources/AppBundle/Controller/Admin/Event/VotesListeAction.php b/sources/AppBundle/Controller/Admin/Event/VotesListeAction.php
@@ -12,9 +12,7 @@
 
 final class VotesListeAction extends AbstractController
 {
-    public function __construct(
-        private readonly VoteRepository $voteRepository,
-    ) {}
+    public function __construct(private readonly VoteRepository $voteRepository,) {}
 
     public function __invoke(Request $request, AdminEventSelection $eventSelection): Response
     {
diff --git a/sources/AppBundle/Controller/Admin/TechLetter/IndexAction.php b/sources/AppBundle/Controller/Admin/TechLetter/IndexAction.php
@@ -12,9 +12,7 @@
 
 final class IndexAction extends AbstractController
 {
-    public function __construct(
-        private readonly SendingRepository $sendingRepository,
-    ) {}
+    public function __construct(private readonly SendingRepository $sendingRepository,) {}
 
     public function __invoke(Request $request): Response
     {
diff --git a/sources/AppBundle/Controller/Admin/TechLetter/MembersAction.php b/sources/AppBundle/Controller/Admin/TechLetter/MembersAction.php
@@ -10,9 +10,7 @@
 
 final class MembersAction extends AbstractController
 {
-    public function __construct(
-        private readonly TechletterSubscriptionsRepository $techletterSubscriptionsRepository,
-    ) {}
+    public function __construct(private readonly TechletterSubscriptionsRepository $techletterSubscriptionsRepository,) {}
 
     public function __invoke(): Response
     {
diff --git a/sources/AppBundle/Controller/Event/Blog/TalkWidgetAction.php b/sources/AppBundle/Controller/Event/Blog/TalkWidgetAction.php
@@ -11,9 +11,7 @@
 
 final class TalkWidgetAction extends AbstractController
 {
-    public function __construct(
-        private readonly TalkRepository $talkRepository,
-    ) {}
+    public function __construct(private readonly TalkRepository $talkRepository,) {}
 
     public function __invoke(Request $request): Response
     {
diff --git a/sources/AppBundle/Controller/Event/Event/CalendarLatestAction.php b/sources/AppBundle/Controller/Event/Event/CalendarLatestAction.php
@@ -10,9 +10,7 @@
 
 final class CalendarLatestAction extends AbstractController
 {
-    public function __construct(
-        private readonly EventRepository $eventRepository,
-    ) {}
+    public function __construct(private readonly EventRepository $eventRepository,) {}
 
     public function __invoke(): RedirectResponse
     {
diff --git a/sources/AppBundle/Controller/Event/Lead/BecomeSponsorLatestAction.php b/sources/AppBundle/Controller/Event/Lead/BecomeSponsorLatestAction.php
@@ -13,9 +13,7 @@
  */
 final class BecomeSponsorLatestAction extends AbstractController
 {
-    public function __construct(
-        private readonly EventRepository $eventRepository,
-    ) {}
+    public function __construct(private readonly EventRepository $eventRepository,) {}
 
     public function __invoke(): RedirectResponse
     {
diff --git a/sources/AppBundle/Controller/Event/Lead/PostLeadAction.php b/sources/AppBundle/Controller/Event/Lead/PostLeadAction.php
@@ -10,9 +10,7 @@
 
 final class PostLeadAction extends AbstractController
 {
-    public function __construct(
-        private readonly EventActionHelper $eventActionHelper,
-    ) {}
+    public function __construct(private readonly EventActionHelper $eventActionHelper,) {}
 
     public function __invoke($eventSlug): Response
     {
diff --git a/sources/AppBundle/Controller/Event/SponsorScan/SponsorScanController.php b/sources/AppBundle/Controller/Event/SponsorScan/SponsorScanController.php
@@ -12,9 +12,7 @@
 
 abstract class SponsorScanController extends AbstractController
 {
-    public function __construct(
-        private readonly SponsorTicketRepository $sponsorTicketRepository,
-    ) {}
+    public function __construct(private readonly SponsorTicketRepository $sponsorTicketRepository,) {}
 
     protected function checkSponsorTicket(Request $request): SponsorTicket
     {
diff --git a/sources/AppBundle/Controller/ValueResolver/AdminEventSelectionValueResolver.php b/sources/AppBundle/Controller/ValueResolver/AdminEventSelectionValueResolver.php
@@ -14,9 +14,7 @@
 #[AsTaggedItem(index: 'admin_event_selection', priority: 150)]
 final readonly class AdminEventSelectionValueResolver implements ValueResolverInterface
 {
-    public function __construct(
-        private EventActionHelper $eventActionHelper,
-    ) {}
+    public function __construct(private EventActionHelper $eventActionHelper,) {}
 
     public function resolve(Request $request, ArgumentMetadata $argument): iterable
     {
diff --git a/sources/AppBundle/Controller/Website/CompanyPublicProfile/CompanyPublicProfileController.php b/sources/AppBundle/Controller/Website/CompanyPublicProfile/CompanyPublicProfileController.php
@@ -10,9 +10,7 @@
 
 abstract class CompanyPublicProfileController extends AbstractController
 {
-    public function __construct(
-        private readonly CompanyMemberRepository $companyMemberRepository,
-    ) {}
+    public function __construct(private readonly CompanyMemberRepository $companyMemberRepository,) {}
 
     protected function checkAndGetCompanyMember(int $id, string $slug): CompanyMember
     {
diff --git a/sources/AppBundle/Controller/Website/Membership/BecomeMemberAction.php b/sources/AppBundle/Controller/Website/Membership/BecomeMemberAction.php
@@ -9,9 +9,7 @@
 
 final readonly class BecomeMemberAction
 {
-    public function __construct(
-        private ViewRenderer $view,
-    ) {}
+    public function __construct(private ViewRenderer $view,) {}
 
     public function __invoke(): Response
     {
diff --git a/sources/AppBundle/Controller/Website/Membership/InvoiceAction.php b/sources/AppBundle/Controller/Website/Membership/InvoiceAction.php
@@ -10,9 +10,7 @@
 
 final class InvoiceAction extends AbstractController
 {
-    public function __construct(
-        private readonly Cotisations $cotisations,
-    ) {}
+    public function __construct(private readonly Cotisations $cotisations,) {}
 
     public function __invoke(string $invoiceNumber, ?string $token): Response
     {
diff --git a/sources/AppBundle/Controller/Website/Static/VoidAction.php b/sources/AppBundle/Controller/Website/Static/VoidAction.php
@@ -10,9 +10,7 @@
 
 final readonly class VoidAction
 {
-    public function __construct(
-        private ViewRenderer $view,
-    ) {}
+    public function __construct(private ViewRenderer $view,) {}
 
     public function __invoke(Request $request): Response
     {
diff --git a/sources/AppBundle/Controller/Website/Techletter/IndexAction.php b/sources/AppBundle/Controller/Website/Techletter/IndexAction.php
@@ -9,9 +9,7 @@
 
 final readonly class IndexAction
 {
-    public function __construct(
-        private ViewRenderer $view,
-    ) {}
+    public function __construct(private ViewRenderer $view,) {}
 
     public function __invoke(): Response
     {
diff --git a/sources/AppBundle/Email/Mailer/Adapter/SymfonyMailerAdapter.php b/sources/AppBundle/Email/Mailer/Adapter/SymfonyMailerAdapter.php
@@ -13,9 +13,7 @@
 
 final readonly class SymfonyMailerAdapter implements MailerAdapter
 {
-    public function __construct(
-        private MailerInterface $mailer,
-    ) {}
+    public function __construct(private MailerInterface $mailer,) {}
 
     public function send(Message $message): void
     {
diff --git a/sources/AppBundle/Event/Form/TicketType.php b/sources/AppBundle/Event/Form/TicketType.php
@@ -88,23 +88,21 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 $filteredEventTickets[] = $eventTicket;
             }
 
-            if ($options['event_id'] !== null) {
-                $event = $this->eventRepository->get($options['event_id']);
-                $ticketSpecialPrice = $this->ticketSpecialPriceRepository->findUnusedToken($event, $options['special_price_token']);
-
-                if (null !== $ticketSpecialPrice) {
-                    $ticketType = $this->ticketTypeRepository->get(Ticket::TYPE_SPECIAL_PRICE);
-
-                    $eToken = new TicketEventType();
-                    $eToken->setDateStart($ticketSpecialPrice->getDateStart());
-                    $eToken->setDateEnd($ticketSpecialPrice->getDateEnd());
-                    $eToken->setPrice($ticketSpecialPrice->getPrice());
-                    $eToken->setTicketType($ticketType);
-                    $eToken->setEventId($ticketSpecialPrice->getEventId());
-                    $eToken->setTicketTypeId(Ticket::TYPE_SPECIAL_PRICE);
-                    $filteredEventTickets = [];
-                    $filteredEventTickets[] = $eToken;
-                }
+            $event = $this->eventRepository->get($options['event_id']);
+            $ticketSpecialPrice = $this->ticketSpecialPriceRepository->findUnusedToken($event, $options['special_price_token']);
+
+            if (null !== $ticketSpecialPrice) {
+                $ticketType = $this->ticketTypeRepository->get(Ticket::TYPE_SPECIAL_PRICE);
+
+                $eToken = new TicketEventType();
+                $eToken->setDateStart($ticketSpecialPrice->getDateStart());
+                $eToken->setDateEnd($ticketSpecialPrice->getDateEnd());
+                $eToken->setPrice($ticketSpecialPrice->getPrice());
+                $eToken->setTicketType($ticketType);
+                $eToken->setEventId($ticketSpecialPrice->getEventId());
+                $eToken->setTicketTypeId(Ticket::TYPE_SPECIAL_PRICE);
+                $filteredEventTickets = [];
+                $filteredEventTickets[] = $eToken;
             }
 
             $formEvent->getForm()->add('ticketEventType', ChoiceType::class, [
diff --git a/sources/AppBundle/Security/Authentication.php b/sources/AppBundle/Security/Authentication.php
@@ -13,9 +13,7 @@
 
 final readonly class Authentication
 {
-    public function __construct(
-        private Security $security,
-    ) {}
+    public function __construct(private Security $security,) {}
 
     public function getAfupUser(): User
     {
diff --git a/sources/AppBundle/Site/Form/FeuilleType.php b/sources/AppBundle/Site/Form/FeuilleType.php
@@ -18,9 +18,7 @@ class FeuilleType extends AbstractType
 {
     public const POSITIONS_RUBRIQUES = 9;
 
-    public function __construct(
-        private readonly FeuilleRepository $feuilleRepository,
-    ) {}
+    public function __construct(private readonly FeuilleRepository $feuilleRepository,) {}
 
     public function buildForm(FormBuilderInterface $builder, array $options): void
     {
diff --git a/sources/AppBundle/StaticAnalysis/Rule/DoctrineDisableDQLRule.php b/sources/AppBundle/StaticAnalysis/Rule/DoctrineDisableDQLRule.php
@@ -21,9 +21,8 @@
 {
     private ClassReflection $entityManagerClass;
 
-    public function __construct(
-        private ReflectionProvider $reflectionProvider,
-    ) {
+    public function __construct(private ReflectionProvider $reflectionProvider,)
+    {
         $this->entityManagerClass = $this->reflectionProvider->getClass(EntityManagerInterface::class);
     }
 
diff --git a/sources/AppBundle/StaticAnalysis/Rule/DoctrineRepositoryRule.php b/sources/AppBundle/StaticAnalysis/Rule/DoctrineRepositoryRule.php
@@ -31,9 +31,8 @@
     private ClassReflection $repositoryClassReflection;
     private ClassReflection $formClassReflection;
 
-    public function __construct(
-        private ReflectionProvider $reflectionProvider,
-    ) {
+    public function __construct(private ReflectionProvider $reflectionProvider,)
+    {
         $this->repositoryClassReflection = $this->reflectionProvider->getClass(EntityRepository::class);
         $this->formClassReflection = $this->reflectionProvider->getClass(AbstractType::class);
     }
diff --git a/sources/AppBundle/StaticAnalysis/Rule/NoGetUserMethodRule.php b/sources/AppBundle/StaticAnalysis/Rule/NoGetUserMethodRule.php
diff --git a/sources/AppBundle/TechLetter/Model/TechLetterFactory.php b/sources/AppBundle/TechLetter/Model/TechLetterFactory.php
diff --git a/sources/AppBundle/Twig/OfficesExtension.php b/sources/AppBundle/Twig/OfficesExtension.php
diff --git a/sources/PlanetePHP/FeedTester.php b/sources/PlanetePHP/FeedTester.php

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,7 @@`
`10`	`10`
`11`	`11`	`final readonly class Page`
`12`	`12`	`{`
`13`		`- public function __construct(`
`14`		`- private FeuilleRepository $feuilleRepository,`
`15`		`- ) {}`
	`13`	`+ public function __construct(private FeuilleRepository $feuilleRepository,) {}`
`16`	`14`
`17`	`15`	`public function header($url = null, UserInterface $user = null): string`
`18`	`16`	`{`
Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,7 @@ class CompanyPublicProfile extends AbstractType`
`27`	`27`	`public const DESCRIPTION_MAX_LENGTH = 2000;`
`28`	`28`	`public const MEMBERSHIP_REASON_MAX_LENGTH = 150;`
`29`	`29`
`30`		`- public function __construct(`
`31`		`- private readonly AntenneRepository $antennesRepository,`
`32`		`- ) {}`
	`30`	`+ public function __construct(private readonly AntenneRepository $antennesRepository,) {}`
`33`	`31`
`34`	`32`	`public function buildForm(FormBuilderInterface $builder, array $options): void`
`35`	`33`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,7 @@`
`11`	`11`
`12`	`12`	`class NearestOfficeChoiceType extends AbstractType`
`13`	`13`	`{`
`14`		`- public function __construct(`
`15`		`- private readonly AntenneRepository $antennesRepository,`
`16`		`- ) {}`
	`14`	`+ public function __construct(private readonly AntenneRepository $antennesRepository,) {}`
`17`	`15`
`18`	`16`	`public function configureOptions(OptionsResolver $resolver): void`
`19`	`17`	`{`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ public function getManager(): bool`
`77`	`77`
`78`	`78`	`public function setManager(bool $manager): self`
`79`	`79`	`{`
`80`		`- $this->propertyChanged('manager', $this->manager ?? null, $manager);`
	`80`	`+ $this->propertyChanged('manager', $this->manager, $manager);`
`81`	`81`	`$this->manager = $manager;`
`82`	`82`	`return $this;`
`83`	`83`	`}`
`@@ -107,7 +107,7 @@ public function getStatus(): int`
`107`	`107`	`*/`
`108`	`108`	`public function setStatus(int $status): self`
`109`	`109`	`{`
`110`		`- $this->propertyChanged('status', $this->status ?? null, $status);`
	`110`	`+ $this->propertyChanged('status', $this->status, $status);`
`111`	`111`	`$this->status = $status;`
`112`	`112`	`return $this;`
`113`	`113`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,8 @@`
`12`	`12`
`13`	`13`	`class UpdateCompanyMemberStateCommand extends Command`
`14`	`14`	`{`
`15`		`- public function __construct(`
`16`		`- private readonly CompanyMemberRepository $companyMemberRepository,`
`17`		`- ) {`
	`15`	`+ public function __construct(private readonly CompanyMemberRepository $companyMemberRepository,)`
	`16`	`+ {`
`18`	`17`	`parent::__construct();`
`19`	`18`	`}`
`20`	`19`
Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,7 @@`
`12`	`12`
`13`	`13`	`class AllocateAction extends AbstractController`
`14`	`14`	`{`
`15`		`- public function __construct(`
`16`		`- private readonly TransactionRepository $transactionRepository,`
`17`		`- ) {}`
	`15`	`+ public function __construct(private readonly TransactionRepository $transactionRepository,) {}`
`18`	`16`
`19`	`17`	`public function __invoke(Request $request, int $id): RedirectResponse`
`20`	`18`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,9 +14,7 @@`
`14`	`14`
`15`	`15`	`class UpdateInfoAction extends AbstractController`
`16`	`16`	`{`
`17`		`- public function __construct(`
`18`		`- private readonly TransactionRepository $transactionRepository,`
`19`		`- ) {}`
	`17`	`+ public function __construct(private readonly TransactionRepository $transactionRepository,) {}`
`20`	`18`
`21`	`19`	`public function __invoke(`
`22`	`20`	`Request $request,`