Apply suggestions from Copilot code review

Byron · Copilot · Byron · commit fd3468bcb226 · 2026-02-20T07:30:56.000+01:00
The comment states "standard for CLI tools on all platforms" but this is inaccurate. On Windows, the standard location for configuration files is in the AppData folder (e.g., %APPDATA% or %LOCALAPPDATA%), not ~/.config. While this code will work on Windows if users manually create the .config directory in their home folder, it doesn't follow Windows conventions. Consider using the dirs crate's config_dir() function instead of manually constructing ~/.config, which will use the appropriate platform-specific directory (e.g., %APPDATA% on Windows, ~/.config on Linux, ~/Library/Application Support on macOS).

The check !glob_focussed is redundant here because self.focussed == Main already ensures we're not in Glob mode (since glob_focussed = self.focussed == Glob on line 250). While this doesn't cause incorrect behavior and may serve as defensive programming, consider removing it for clarity since the condition self.focussed == Main already guarantees !glob_focussed.

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/src/config.rs b/src/config.rs
@@ -43,11 +43,9 @@ impl Config {
     }
 
     fn path() -> Option<PathBuf> {
-        // Use $XDG_CONFIG_HOME if set, otherwise ~/.config (standard for CLI tools on all platforms).
-        let config_dir = std::env::var_os("XDG_CONFIG_HOME")
-            .map(PathBuf::from)
-            .filter(|p| p.is_absolute())
-            .or_else(|| dirs::home_dir().map(|h| h.join(".config")))?;
+        // Use the OS-specific configuration directory (e.g. $XDG_CONFIG_HOME, %APPDATA%, or
+        // ~/Library/Application Support) as provided by the `dirs` crate.
+        let config_dir = dirs::config_dir()?;
         Some(config_dir.join("dua-cli").join("config.toml"))
     }
 }
diff --git a/src/interactive/app/eventloop.rs b/src/interactive/app/eventloop.rs
@@ -251,7 +251,7 @@ impl AppState {
         let mut tree_view = self.tree_view(traversal);
 
         let esc_navigates_back_in_main =
-            self.esc_navigates_back && key.code == Esc && self.focussed == Main && !glob_focussed;
+            self.esc_navigates_back && key.code == Esc && self.focussed == Main;
 
         if esc_navigates_back_in_main {
             self.pending_exit = false;

Original file line number	Diff line number	Diff line change
`@@ -43,11 +43,9 @@ impl Config {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`fn path() -> Option<PathBuf> {`
`46`		`- // Use $XDG_CONFIG_HOME if set, otherwise ~/.config (standard for CLI tools on all platforms).`
`47`		`- let config_dir = std::env::var_os("XDG_CONFIG_HOME")`
`48`		`- .map(PathBuf::from)`
`49`		`- .filter(\|p\| p.is_absolute())`
`50`		`- .or_else(\|\| dirs::home_dir().map(\|h\| h.join(".config")))?;`
	`46`	`+ // Use the OS-specific configuration directory (e.g. $XDG_CONFIG_HOME, %APPDATA%, or`
	`47`	+ // ~/Library/Application Support) as provided by the `dirs` crate.
	`48`	`+ let config_dir = dirs::config_dir()?;`
`51`	`49`	`Some(config_dir.join("dua-cli").join("config.toml"))`
`52`	`50`	`}`
`53`	`51`	`}`