fix: Color/Name::from_str()` won't panic when encountering unicode values.

Byron · Byron · commit f9d566f82b86 · 2024-01-01T09:52:57.000+01:00
Previously it would try to byte-index a presumed ascii string to convert
hex to RGB, which could panic if the string wasn't actually ascii.

Now it validates that the characters to convert are actually on a character
boundary.
diff --git a/gix-config-value/src/color.rs b/gix-config-value/src/color.rs
@@ -204,7 +204,7 @@ impl FromStr for Name {
         }
 
         if let Some(s) = s.strip_prefix('#') {
-            if s.len() == 6 {
+            if s.len() == 6 && s.is_char_boundary(2) && s.is_char_boundary(4) && s.is_char_boundary(6) {
                 let rgb = (
                     u8::from_str_radix(&s[..2], 16),
                     u8::from_str_radix(&s[2..4], 16),
diff --git a/gix-config-value/tests/value/color.rs b/gix-config-value/tests/value/color.rs
@@ -54,6 +54,7 @@ mod name {
         assert!(Name::from_str("#").is_err());
         assert!(Name::from_str("#fff").is_err());
         assert!(Name::from_str("#gggggg").is_err());
+        assert!(Name::from_str("#=»©=").is_err());
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ impl FromStr for Name {`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`if let Some(s) = s.strip_prefix('#') {`
`207`		`- if s.len() == 6 {`
	`207`	`+ if s.len() == 6 && s.is_char_boundary(2) && s.is_char_boundary(4) && s.is_char_boundary(6) {`
`208`	`208`	`let rgb = (`
`209`	`209`	`u8::from_str_radix(&s[..2], 16),`
`210`	`210`	`u8::from_str_radix(&s[2..4], 16),`
Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ mod name {`
`54`	`54`	`assert!(Name::from_str("#").is_err());`
`55`	`55`	`assert!(Name::from_str("#fff").is_err());`
`56`	`56`	`assert!(Name::from_str("#gggggg").is_err());`
	`57`	`+ assert!(Name::from_str("#=»©=").is_err());`
`57`	`58`	`}`
`58`	`59`	`}`
`59`	`60`