git-baseline now acts like a massive regression test (#301)

Byron · Byron · commit fe3d0a778210 · 2022-04-09T10:22:12.000+08:00
Thus it will only keep a failure count, which we try to boost to 100%
over time.
diff --git a/git-glob/src/lib.rs b/git-glob/src/lib.rs
@@ -78,7 +78,7 @@ pub mod pattern {
                     Case::Fold => MatchOptions::IGNORE_CASE,
                     Case::Sensitive => MatchOptions::empty(),
                 };
-            todo!()
+            false
         }
 
         pub fn matches(&self, _value: &BStr, _options: MatchOptions) -> bool {
diff --git a/git-glob/tests/matching/mod.rs b/git-glob/tests/matching/mod.rs
@@ -44,6 +44,7 @@ impl<'a> Baseline<'a> {
 #[ignore]
 fn compare_baseline_with_ours() {
     let dir = git_testtools::scripted_fixture_repo_read_only("make_baseline.sh").unwrap();
+    let (mut total_matches, mut total_correct) = (0, 0);
     for (input_file, expected_matches) in &[("git-baseline.match", true), ("git-baseline.nmatch", false)] {
         let input = std::fs::read(dir.join(*input_file)).unwrap();
         let mut seen = BTreeSet::default();
@@ -54,24 +55,27 @@ fn compare_baseline_with_ours() {
             is_match,
         } in Baseline::new(&input)
         {
+            total_matches += 1;
             assert!(seen.insert(m), "duplicate match entry: {:?}", m);
             assert_eq!(
                 is_match, *expected_matches,
                 "baseline for matches must indeed be {} - check baseline and git version: {:?}",
                 expected_matches, m
             );
             let pattern = git_glob::Pattern::from_bytes(pattern).expect("parsing works");
-            assert_eq!(
-                pattern.matches_path(
-                    value,
-                    value.rfind_byte(b'/').map(|pos| pos + 1),
-                    false, // TODO: does it make sense to pretent it is a dir and see what happens?
-                    pattern::Case::Sensitive
-                ),
-                is_match
-            )
+            let actual_match = pattern.matches_path(
+                value,
+                value.rfind_byte(b'/').map(|pos| pos + 1),
+                false, // TODO: does it make sense to pretent it is a dir and see what happens?
+                pattern::Case::Sensitive,
+            );
+            if actual_match == is_match {
+                total_correct += 1;
+            }
         }
     }
+
+    assert_eq!(total_correct, total_matches, "We perfectly agree with git here");
 }
 
 #[test]

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ pub mod pattern {`
`78`	`78`	`Case::Fold => MatchOptions::IGNORE_CASE,`
`79`	`79`	`Case::Sensitive => MatchOptions::empty(),`
`80`	`80`	`};`
`81`		`- todo!()`
	`81`	`+ false`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`pub fn matches(&self, _value: &BStr, _options: MatchOptions) -> bool {`