add history days and timeout params to config file #14
Conversation
A default value for job history query parameter days and command timeout can be set through the scom.conf file now. This allows changing the default value of these parameters while still allowing users to specify `-d` and `-t` flags.
pja237
left a comment
There was a problem hiding this comment.
Hey @hv15,
sorry for the delayed response, we're still in the holiday/restructuring mode of work.
Love your additions, thank you very much for the contribution, all looks perfect to me.
Just to make sure we're on the same page regarding the -S param? That would be like slurm start time specifier? or i misunderstood it?
In principle, i see any addition that makes people lives easier as a good one/worth exploring. Time-wise, might take me some to get to attacking that, so safest place for such ideas would be to just queue them in Issues, and we can do them as we find free time.
Also, would you have anything against signing yourself as a contributor in the "thank you" section of the about tab before i merge and release? 😃
SlurmCommander/internal/model/view.go
Lines 51 to 56 in b7abca5
Hi, just came across this project via SLURM-user mailing list. Really useful tool, thank you! For our cluster we're looking to add it. We'd like to by default have job history days and timeout set to different values.
With this PR we add entries to the scom.conf file to set new defaults for both job history query parameter days and command timeout. This allows changing the default value of these parameters while still allowing users to specify
-dand-tflags.Possibly being able to set (or pass) a
-Sargs might also be worth exploring.