-
Notifications
You must be signed in to change notification settings - Fork 888
Open
Labels
A-configArea: Config API and UIArea: Config API and UIF-good-first-issueFlag: Good first issue for new contributorsFlag: Good first issue for new contributorsT-bugType: BugType: Bug
Milestone
Description
Request Description
The name of the "General" tab cannot be translated using the translation key because it simply does not exist.
If I understand correctly, this is because Component.literal (prints the text as is) is used instead of Component.translatable (uses the translation key) in the string var generalPage = builder.createOptionPage().setName(Component.literal("General")); in the SodiumConfigBuilder.java class.
So I suggest using something like var generalPage = builder.createOptionPage().setName(Component.translatable("sodium.options.pages.general"));.
I could create a pull request, but I'm not sure what I'm suggesting is correct.
Metadata
Metadata
Assignees
Labels
A-configArea: Config API and UIArea: Config API and UIF-good-first-issueFlag: Good first issue for new contributorsFlag: Good first issue for new contributorsT-bugType: BugType: Bug