-
-
Notifications
You must be signed in to change notification settings - Fork 397
Closed
Labels
Description
Cantera version
2.4.0 / 2.5.0a
Operating System
all
Python/MATLAB version
all Python
Expected Behavior
External (and built-in) modules should not be added to the cantera package as they are not part of cantera, e.g. numpy, math, os, sys, weakref, erf, warnings, appdelete, ...
While they are obviously required internally, they should not necessarily be exposed (can be avoided by defining __all__ in modules where cantera objects/functions are defined, so the from <> import * in __init__.py will only include what needs to be exposed).
Actual Behavior
cantera.np is numpy (external project), cantera.math is math (built-in), etc.
While this is admittedly a minor issue, it conflicts with PEP 423 as it obfuscates the origin of modules (np), and needlessly creates an additional level.
Steps to reproduce
import cantera as ctdir(ct)includes both cantera and non-cantera modules