Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Optional parameter uri filter #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Optional parameter uri filter #10

wants to merge 2 commits into from

Conversation

cksapp
Copy link
Contributor

@cksapp cksapp commented Jan 1, 2025

fixes minor grammar and cmdlet naming in description

Pull Request

Description

Updates the ConvertTo-DattoQueryString function to allow optional uri_Filter parameter, to

Fixes: #9

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have reviewed the Contributing guide
  • I am pulling to the main branch
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Confirmed does not include query parameter when not specified, will add this as single object or array as well when passed for query parameter
May need to confirm no other breaking changes in query filter for functions but should be behaving the same

@cksapp
Copy link
Contributor Author

cksapp commented Apr 22, 2025

@Celerium just wanted to ping on this and touch base, for this PR would you prefer smaller pull requests for each change or just make all required changes for $uri_Filter and newly (yet to be added) -seatType parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Invoke-DattoRequest function -uri_Filter parameter optional, but required in helper function ConvertTo-DattoQueryString
1 participant
@cksapp