Log the more raw error message from Twirp

JamesMGreene · JamesMGreene · commit d6fbcf80b196 · 2023-12-22T12:53:15.000-06:00
diff --git a/src/__tests__/internal/deployment.test.js b/src/__tests__/internal/deployment.test.js
@@ -194,6 +194,11 @@ describe('Deployment', () => {
       )
       expect(core.error).toHaveBeenNthCalledWith(
         1,
+        'Listing artifact metadata failed',
+        new Error('Failed to ListArtifacts: Received non-retryable error: Failed request: (400) null: yikes!')
+      )
+      expect(core.error).toHaveBeenNthCalledWith(
+        2,
         'Fetching artifact metadata failed. Is githubstatus.com reporting issues with API requests, Pages, or Actions? Please re-run the deployment at a later time.',
         expect.any(Error)
       )
@@ -416,6 +421,11 @@ describe('Deployment', () => {
       )
       expect(core.error).toHaveBeenNthCalledWith(
         1,
+        'Listing artifact metadata failed',
+        new Error('Failed to ListArtifacts: Received non-retryable error: Failed request: (501) null: oh no')
+      )
+      expect(core.error).toHaveBeenNthCalledWith(
+        2,
         'Fetching artifact metadata failed. Is githubstatus.com reporting issues with API requests, Pages, or Actions? Please re-run the deployment at a later time.',
         expect.any(Error)
       )
diff --git a/src/internal/api-client.js b/src/internal/api-client.js
@@ -70,6 +70,7 @@ async function getArtifactMetadata({ artifactName }) {
       const twirpResponse = await artifactClient.listArtifacts()
       response = wrapTwirpResponseLikeOctokit(twirpResponse, requestOptions)
     } catch (twirpError) {
+      core.error('Listing artifact metadata failed', twirpError)
       const octokitError = wrapTwirpErrorLikeOctokit(twirpError, requestOptions)
       throw octokitError
     }

Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,11 @@ describe('Deployment', () => {`
`194`	`194`	`)`
`195`	`195`	`expect(core.error).toHaveBeenNthCalledWith(`
`196`	`196`	`1,`
	`197`	`+ 'Listing artifact metadata failed',`
	`198`	`+ new Error('Failed to ListArtifacts: Received non-retryable error: Failed request: (400) null: yikes!')`
	`199`	`+ )`
	`200`	`+ expect(core.error).toHaveBeenNthCalledWith(`
	`201`	`+ 2,`
`197`	`202`	`'Fetching artifact metadata failed. Is githubstatus.com reporting issues with API requests, Pages, or Actions? Please re-run the deployment at a later time.',`
`198`	`203`	`expect.any(Error)`
`199`	`204`	`)`
`@@ -416,6 +421,11 @@ describe('Deployment', () => {`
`416`	`421`	`)`
`417`	`422`	`expect(core.error).toHaveBeenNthCalledWith(`
`418`	`423`	`1,`
	`424`	`+ 'Listing artifact metadata failed',`
	`425`	`+ new Error('Failed to ListArtifacts: Received non-retryable error: Failed request: (501) null: oh no')`
	`426`	`+ )`
	`427`	`+ expect(core.error).toHaveBeenNthCalledWith(`
	`428`	`+ 2,`
`419`	`429`	`'Fetching artifact metadata failed. Is githubstatus.com reporting issues with API requests, Pages, or Actions? Please re-run the deployment at a later time.',`
`420`	`430`	`expect.any(Error)`
`421`	`431`	`)`
Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ async function getArtifactMetadata({ artifactName }) {`
`70`	`70`	`const twirpResponse = await artifactClient.listArtifacts()`
`71`	`71`	`response = wrapTwirpResponseLikeOctokit(twirpResponse, requestOptions)`
`72`	`72`	`} catch (twirpError) {`
	`73`	`+ core.error('Listing artifact metadata failed', twirpError)`
`73`	`74`	`const octokitError = wrapTwirpErrorLikeOctokit(twirpError, requestOptions)`
`74`	`75`	`throw octokitError`
`75`	`76`	`}`