Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix for compilation on GCC 10.2.1 / FC32 #55

@rpopescu

Description

@rpopescu

Hi,

This is a trivial fix for a compilation failure that happens in newer GCC, probably due to internal header include cleanup.
First the error:

20/57] Building CXX object clickhouse/CMakeFiles/clickhouse-cpp-lib-static.dir/types/types.cpp.o
FAILED: clickhouse/CMakeFiles/clickhouse-cpp-lib-static.dir/types/types.cpp.o 
/usr/bin/c++   -I../. -I../contrib -O2 -pthread -Wall -Wextra -Werror -O2 -DNDEBUG   -std=gnu++17 -MD -MT clickhouse/CMakeFiles/clickhouse-cpp-lib-static.dir/types/types.cpp.o -MF clickhouse/CMakeFiles/clickhouse-cpp-lib-static.dir/types/types.cpp.o.d -o clickhouse/CMakeFiles/clickhouse-cpp-lib-static.dir/types/types.cpp.o -c ../clickhouse/types/types.cpp
../clickhouse/types/types.cpp: In constructor ‘clickhouse::DateTime64Type::DateTime64Type(size_t)’:
../clickhouse/types/types.cpp:234:20: error: ‘runtime_error’ is not a member of ‘std’
  234 |         throw std::runtime_error("DateTime64 precision is > 18");
      |                    ^~~~~~~~~~~~~

This is fixed by adding the missing header, of course:

diff --git a/clickhouse/types/types.cpp b/clickhouse/types/types.cpp
index 0eaf939..b273364 100644
--- a/clickhouse/types/types.cpp
+++ b/clickhouse/types/types.cpp
@@ -1,6 +1,7 @@
 #include "types.h"
 
-#include <assert.h>
+#include <stdexcept>
+#include <cassert> 

 namespace clickhouse {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions