-
Notifications
You must be signed in to change notification settings - Fork 179
Support Date32 data type. #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
huyphams
commented
Apr 27, 2022
- Added date32 (Which is 4 bytes when compared with 2 byte Date).
I think I should add a test for Date32 |
Hi, thank you for contribution! Yes, please add some tests. There are two kinds of them:
If you find it difficult adding both, please add at least something and allow |
clickhouse/types/types.h
Outdated
@@ -34,6 +34,7 @@ class Type { | |||
FixedString, | |||
DateTime, | |||
Date, | |||
Date32, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the new value to the end. This is enum
is visible to users and some may rely on order of elements. I think we can re-arrange those to look better in a next major version, like 3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix minor issue mentioned
Thank you for reviewing, I will fix it 🙌 |
Please rebase/merge master and fix the builds |
Hi @Enmk I've merged master into this branch. Could you help me to write the test (if you have time)? 🙌 |
Sure, I've drafted a scaffold for unit-testing Column implementation. Will try to finalize and commit it on Monday. |
Hello @huyphams ! In order to benefit form test suite, you'll need to make some changes to the
If you have some very specific test cases, that are not covered by generic test suite, you can add those into Also you are welcome to review the pr #179 |
@huyphams ping? |