Fix getaddrinfo error reporting #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Enmk
reviewed
Jan 7, 2023
| @@ -60,6 +60,18 @@ class windowsErrorCategory : public std::error_category { | |||
|
|
|||
| #endif | |||
|
|
|||
| #if defined(_unix_) | |||
|
|
|||
| class getaddrinfoErrorCategory : public std::error_category { | |||
There was a problem hiding this comment.
Do you have to make it part of the API, i.e. visible to the users? IMO it would be better to move declaration to .cpp
There was a problem hiding this comment.
There's no requirement for it to be public. But users will have access to it through e.code().category() and nothing to compare it to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getaddrinfoerror reporting is currently broken on non-Windows platforms as only a subset of its errors are reported viaerrno.(On Windows everything gets combined in
WSAGetLastError()andgai_strerroris declared not thread-safe for some reason.)