Fix action sheet delegate on iPad running iOS 8 GM

chrisze · chrisze · commit 304452b41e0f · 2014-09-15T17:00:19.000-07:00
diff --git a/BlocksKit/UIKit/UIActionSheet+BlocksKit.m b/BlocksKit/UIKit/UIActionSheet+BlocksKit.m
@@ -11,6 +11,8 @@
 
 @interface A2DynamicUIActionSheetDelegate : A2DynamicDelegate <UIActionSheetDelegate>
 
+@property (nonatomic, assign) BOOL didHandleButtonClick;
+
 @end
 
 @implementation A2DynamicUIActionSheetDelegate
@@ -22,7 +24,18 @@ - (void)actionSheet:(UIActionSheet *)actionSheet clickedButtonAtIndex:(NSInteger
 		[realDelegate actionSheet:actionSheet clickedButtonAtIndex:buttonIndex];
 	
 	void (^block)(void) = self.handlers[@(buttonIndex)];
-	if (block) block();
+
+  // Note: On iPad with iOS 8 GM seed, `actionSheet:clickedButtonAtIndex:` always gets called twice if you tap any button other than Cancel;
+  // In other words, assume you have two buttons: OK and Cancel; if you tap OK, this method will be called once for the OK button and once
+  // for the Cancel button. This could result in some really obscure bugs, so adding `didHandleButtonClick` property maintains iOS 7 compatibility.
+  if (block && self.didHandleButtonClick == NO) {
+    self.didHandleButtonClick = YES;
+
+    // Presenting view controllers from within action sheet delegate does not work on iPad running iOS 8 GM seed, without delay
+    dispatch_async(dispatch_get_main_queue(), ^{
+      block();
+    });
+  }
 }
 
 - (void)willPresentActionSheet:(UIActionSheet *)actionSheet
