Split lines by new line characters

jonathanchu · jonathanchu · commit 73ab28744df3 · 2016-05-24T11:19:14.000-04:00
Opt to split lines by the new line character instead of letting
`splitlines()` do this. This helps catch the issue when there are
special characters in the line, particular the commit summary section.
diff --git a/git/repo/base.py b/git/repo/base.py
@@ -682,10 +682,12 @@ def blame_incremental(self, rev, file, **kwargs):
         data = self.git.blame(rev, '--', file, p=True, incremental=True, stdout_as_string=False, **kwargs)
         commits = dict()
 
-        stream = iter(data.splitlines())
+        stream = iter(data.split(b'\n'))
         while True:
             line = next(stream)  # when exhausted, casues a StopIteration, terminating this function
-
+            if line.strip() == '':
+                # Skip over empty lines
+                continue
             hexsha, orig_lineno, lineno, num_lines = line.split()
             lineno = int(lineno)
             num_lines = int(num_lines)
diff --git a/git/test/fixtures/blame_incremental b/git/test/fixtures/blame_incremental
@@ -7,7 +7,7 @@ committer Sebastian Thiel
 committer-mail <byronimo@gmail.com>
 committer-time 1270634931
 committer-tz +0200
-summary Used this release for a first beta of the 0.2 branch of development
+summary Used this release for a first beta of the 0.2 branch of development
 previous 501bf602abea7d21c3dbb409b435976e92033145 AUTHORS
 filename AUTHORS
 82b8902e033430000481eb355733cd7065342037 14 14 1
