Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make the REFPROP wrapper code 1% more sane #332

@ibell

Description

@ibell

@jowr, I just realized that the getFunctionPointer() function works with const char *. What that means is that we can re-write this function to first try the "normal" function name, then the gfortran one, then the other, since they are always the same letters, just either normal case, all lowercase or all lowercase+_ .

The good part is this means only one set of macros to support, and might mean that we can remove 50% of the REFPROP header if I am not mistaken. I had to add 4 functions to REFPROP when working on derivatives, and it is quite a pain. There are 8 places you need to add code for each one - a real maintenance nightmare.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions