Remove pageNotFound key from the error.

arunoda · arunoda · commit 6f9b51fce6e7 · 2017-04-11T14:51:28.000+05:30
diff --git a/lib/error.js b/lib/error.js
@@ -5,13 +5,12 @@ import Head from './head'
 export default class Error extends React.Component {
   static getInitialProps ({ res, err }) {
     const statusCode = res ? res.statusCode : (err ? err.statusCode : null)
-    const pageNotFound = statusCode === 404 || (err ? err.pageNotFound : false)
-    return { statusCode, pageNotFound }
+    return { statusCode }
   }
 
   render () {
-    const { statusCode, pageNotFound } = this.props
-    const title = pageNotFound
+    const { statusCode } = this.props
+    const title = statusCode === 404
       ? 'This page could not be found'
       : HTTPStatus[statusCode] || 'An unexpected error has occurred'
 
diff --git a/lib/router/router.js b/lib/router/router.js
@@ -208,7 +208,7 @@ export default class Router {
         return { error: err }
       }
 
-      if (err.pageNotFound) {
+      if (err.statusCode === 404) {
         // Indicate main error display logic to
         // ignore rendering this error as a runtime error.
         err.ignore = true
diff --git a/server/render.js b/server/render.js
@@ -124,7 +124,6 @@ export async function renderScriptError (req, res, page, error, customFields, op
     res.end(`
       function loadPage () {
         var error = new Error('Page not exists: ${page}')
-        error.pageNotFound = true
         error.statusCode = 404
         __NEXT_PAGE_LOADER__.registerPage('${page}', function(cb) {
           cb(error)

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ export default class Router {`
`208`	`208`	`return { error: err }`
`209`	`209`	`}`
`210`	`210`
`211`		`- if (err.pageNotFound) {`
	`211`	`+ if (err.statusCode === 404) {`
`212`	`212`	`// Indicate main error display logic to`
`213`	`213`	`// ignore rendering this error as a runtime error.`
`214`	`214`	`err.ignore = true`