Fixed issue where an index in qs_parse is incorrectly incremented beyond the maximum possible value

The-EDev · The-EDev · commit 79eec91f00b5 · 2022-06-27T22:38:24.000+03:00
diff --git a/include/crow/query_string.h b/include/crow/query_string.h
@@ -119,11 +119,10 @@ inline int qs_parse(char* qs, char* qs_kv[], int qs_kv_size, bool parse_url = tr
     {
         qs_kv[i] = substr_ptr;
         j = strcspn(substr_ptr, "&");
-        if ( substr_ptr[j] == '\0' ) {  break;  }
+        if ( substr_ptr[j] == '\0' ) { i++; break;  } // x &'s -> means x iterations of this loop -> means *x+1* k/v pairs
         substr_ptr += j + 1;
         i++;
     }
-    i++;  // x &'s -> means x iterations of this loop -> means *x+1* k/v pairs
 
     // we only decode the values in place, the keys could have '='s in them
     // which will hose our ability to distinguish keys from values later

Original file line number	Diff line number	Diff line change
`@@ -119,11 +119,10 @@ inline int qs_parse(char* qs, char* qs_kv[], int qs_kv_size, bool parse_url = tr`
`119`	`119`	`{`
`120`	`120`	`qs_kv[i] = substr_ptr;`
`121`	`121`	`j = strcspn(substr_ptr, "&");`
`122`		`- if ( substr_ptr[j] == '\0' ) { break; }`
	`122`	`+ if ( substr_ptr[j] == '\0' ) { i++; break; } // x &'s -> means x iterations of this loop -> means x+1 k/v pairs`
`123`	`123`	`substr_ptr += j + 1;`
`124`	`124`	`i++;`
`125`	`125`	`}`
`126`		`- i++; // x &'s -> means x iterations of this loop -> means x+1 k/v pairs`
`127`	`126`
`128`	`127`	`// we only decode the values in place, the keys could have '='s in them`
`129`	`128`	`// which will hose our ability to distinguish keys from values later`