Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DKE-Data/agrirouter-sdk-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.0.0
Choose a base ref
...
head repository: DKE-Data/agrirouter-sdk-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.1.0
Choose a head ref
  • 3 commits
  • 12 files changed
  • 1 contributor

Commits on May 16, 2024

  1. Bugfix/remove duplicate header declaration (#217) 

    * Simplify request creation in RequestFactory

This change consolidates the creation and acceptance of JSON type requests into a single line in the RequestFactory class. This refactoring boosts code readability and efficiency.

* Refactor bearerTokenRequest method in RequestFactory

Removed the redundant client creation and configuration logic within the bearerTokenRequest method in the RequestFactory class. Moreover, a separate method is introduced to generate a request with bearer token allowing simplification and code reuse. The change ensures cleaner and more efficient request generation.

* Update onboarding parameters and response for farming software tests

The onboarding parameters and response for the farming software tests have been updated. This includes changes to the registration code and a new response in the farming-software.json file which includes new id values and URLs.

* Update registration code and onboarding responses in tests

In the FarmingSoftwareFixture.java test file, the placeholder for the registration code has been replaced with an actual code and the test case has been enabled. Additionally, the onboarding response for farming-software-deactivated.json has been updated. These changes are essential to ensure that the tests can run successfully and reflect the current state of the system.

* Update registration code and authentication details in tests

The update involves renewing the registration code used in the farming software fixture for tests. Also, the authentication detail of the farming software in the test JSON response is updated to ensure the effectiveness and relevancy of the tests.

* Enable testcase and update registration code in FarmingSoftwareFixture

The placeholder for the registration code in the test case "onboardAndDeactivateFarmingSoftwareAndSaveToFile" in FarmingSoftwareFixture file has been updated with actual code, and the test case is enabled back for execution. Additionally, relevant changes were made in the "farming-software-deactivated.json" file.
    @saschadoemer
    saschadoemer authored May 16, 2024
    Configuration menu
    Copy the full SHA
    4e97b8c View commit details
    Browse the repository at this point in the history

  2. Bugfix/remove env from set capabilities service since its not used (#216 

    )

* Refactor SetCapabilityServiceImpl constructor and usages

This commit removes the unnecessary environment dependency in SetCapabilityServiceImpl's constructor and adjusts all corresponding usages. This makes the SetCapabilityServiceImpl more loosely coupled, enhancing readability and making it easier to maintain. Removal of the parameter also simplifies its instantiation in tests and reduces potential issues related to varying environments.

* Remove unused import in SetCapabilityServiceTest

The unused import, 'com.dke.data.agrirouter.api.env.QA', was removed from the class 'SetCapabilityServiceTest'. This cleanup improves the readability of the code and adheres to good coding practices.

* Deprecate SetCapabilityServiceImpl constructor in SDK

The SetCapabilityServiceImpl constructor that takes an Environment parameter has been deprecated. A warning message has been added to indicate that this constructor is deprecated, and it should not be used moving forward as it will be removed in a future release. This change aims to streamline the use of the SetCapabilityService requiring no environment parameters.
    @saschadoemer
    saschadoemer authored May 16, 2024
    Configuration menu
    Copy the full SHA
    2a0e152 View commit details
    Browse the repository at this point in the history

  3. Feature/prepare release 3 1 0 (#218) 

    * Update version of agrirouter SDK Java packages to 3.1.0

This update changes the version number of the agrirouter SDK Java packages in the pom.xml files. It affects the primary package agrirouter-sdk-java and its sub-packages: agrirouter-sdk-java-api, agrirouter-sdk-java-convenience, agrirouter-sdk-java-impl, and agrirouter-sdk-java-tests.

* Update dependency versions in pom.xml

In this commit, the version numbers for Gson, Protobuf, and Guava dependencies in the pom.xml file have been updated to their latest versions. This is in line with the commitment to ensure that the project uses the most recent and supported versions of these libraries.

* Remove redundant source folders in pom.xml

These changes remove 'src/main/java' and 'src/main/kotlin' from the list of sources inside pom.xml. It appears they were unneeded and potentially caused confusion or inefficiencies, hence their removal is beneficial.
    @saschadoemer
    saschadoemer authored May 16, 2024
    Configuration menu
    Copy the full SHA
    f781eaa View commit details
    Browse the repository at this point in the history
Loading