don't rely on internal JSON encoding format for requests

oliverrahner · oliverrahner · commit 84f390d409a3 · 2021-10-20T15:03:29.000+02:00
diff --git a/agrirouter/onboarding/onboarding.py b/agrirouter/onboarding/onboarding.py
@@ -34,7 +34,7 @@ def _perform_request(self, params: BaseOnboardingParameter, url: str) -> request
         if request.is_signed:
             return requests.post(
                 url=request.get_url(),
-                json=request.get_data(),
+                data=request.get_body_content(),
                 headers=request.get_header()
             )
         raise RequestNotSigned
@@ -74,7 +74,7 @@ def _perform_request(self, params: CUOnboardingParameter, url: str) -> requests.
         if request.is_signed:
             return requests.post(
                 url=request.get_url(),
-                data=request.get_data(),
+                data=request.get_body_content(),
                 headers=request.get_header()
             )
         raise RequestNotSigned
diff --git a/agrirouter/onboarding/request.py b/agrirouter/onboarding/request.py
@@ -18,8 +18,11 @@ def get_data(self):
     def get_header(self):
         return self.header.get_header()
 
+    def get_body_content(self):
+        return self.body.json().replace("\n", "")
+
     def sign(self, private_key, public_key):
-        body = self.body.json().replace("\n", "")
+        body = self.get_body_content()
         signature = create_signature(body, private_key)
         verify_signature(body, bytes.fromhex(signature), public_key)
         self.header.sign(signature)
diff --git a/agrirouter/onboarding/request_body.py b/agrirouter/onboarding/request_body.py
@@ -75,7 +75,7 @@ def _set_params(self,
         }
 
     def json(self) -> str:
-        return json.dumps(self.get_parameters())
+        return json.dumps(self.get_parameters(), separators=(',', ':'))
 
     @staticmethod
     def _validate_certificate_type(certificate_type: str) -> None:

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ def _set_params(self,`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`def json(self) -> str:`
`78`		`- return json.dumps(self.get_parameters())`
	`78`	`+ return json.dumps(self.get_parameters(), separators=(',', ':'))`
`79`	`79`
`80`	`80`	`@staticmethod`
`81`	`81`	`def _validate_certificate_type(certificate_type: str) -> None:`